Remove mandatory -DCMAKE_BUILD_TYPE

[dvrogozh]

Please, remove mandatory -DCMAKE_BUILD_TYPE and default it to Release inside your cmake files if it is not defined by the user.

[dvrogozh]

@chivakker : FYI

[iwwu]

work in progress. I will update when it is available.

[iwwu]

Request completed. Please use latest code or tag 'igc_release_2018-12-12'. README is updated as well.

[dvrogozh]

@iwwu. I have strong suggestion to you. Please, start add "Fixes: #xxx" to commit messages if you fix github issues. For example, this commit 03dd5d5 should actually have this commit message:

Remove CMAKE_BUILD_TYPE & IGC_OPTION__ARCHITECTURE_TARGET from Cmake cmd

Fixes: #32, #34

CMAKE_BUILD_TYPE is set to Release by default
IGC_OPTION__ARCHITECTURE_TARGET is self detected.

Change-Id: I55cc63051f0b36a60b370e1894258a9f2d309160

There are the following reasons to that:

1. People will easily see which issues are fixed in the log and be able to go to the discussion
2. GitHub will automatically update the issue that commit appeared referencing it. Thus, people monitoring issues list will see that something has changed/going on.
3. GitHub will automatically close the issue if it will see this line (if issue is not fixed author will reopen - that's his responsibility)

[dvrogozh]

@iwwu : Another suggestion is to submit PRs on the GitHub. You should give a chance for people to review/comment/try.

[iwwu]

Closing the issue since the fix is already merged.

[dvrogozh]

works for me. thank you.