Flatpak session (a.k.a. flatpak-based app fw) support. #198

klihub · 2017-06-16T17:59:18Z

This patch set adds flatpak-session support to meta-flatpak on top of the existing basic flatpak support.

This mostly consists of

a daemon for monitoring configured flatpak remotes, pulling in/updating published apps
a systemd generator to set up 'flatpak sessions' for monitored flatpak repositories during boot
a helper binary to launch flatpak applications belonging to a 'flatpak session'
optionally a set of pre-declared flatpak remotes/repositories to preconfigure the images with (IOW set up remote URL, signing public key, and associated session user)

flatpak-session support has its dedicated DISTRO_FEATURE ('flatpak-session'). There is also a corresponding flatpak-session.inc configuration fragment which is used to enable flatpak-sessions.

By default flatpak-session support is disabled.

ipuustin · 2017-06-19T12:35:13Z

meta-flatpak/recipes-flatpak/flatpak-utils/files/flatpak-utils/src/flatpak.c

+
+    i = strtol(val, &e, 10);
+
+    if (!e && !*e)


Should be if (e && !*e)?

Thanks, well spotted.

ipuustin · 2017-06-20T07:22:07Z

meta-flatpak/recipes-flatpak/flatpak-utils/flatpak-utils_git.bb

+
+SYSTEMD_PACKAGES      += "${PN}"
+SYSTEMD_SERVICE_${PN}  = "flatpak-sessions.target flatpak-update.service"
+SYSTEMD_AUTO_ENABLE    = "enable"


This is enable by default, no need to set it. And anyway if you set it, you might want to use ?=.

Removed SYSTEMD_AUTO_ENABLE.

ipuustin · 2017-06-20T07:22:38Z

meta-flatpak/recipes-flatpak/flatpak-utils/flatpak-utils_git.bb

+EXTRA_OECONF += "--with-systemdunitdir=${systemd_unitdir}"
+
+# possible package configurations
+PACKAGECONFIG ??= ""


Hmm, why is this needed?

Removed empty PACKAGECONFIG.

ipuustin · 2017-06-20T07:24:06Z

meta-flatpak/recipes-flatpak/flatpak-utils/flatpak-utils_0.0.bb


 SRC_URI = " \
-    git://git@github.com/klihub/flatpak-utils.git;protocol=https;branch=master \
+    file://flatpak-utils \


You shouldn't patch a file which you introduced in the same PR. Just change it.

Squashed commits.

ipuustin · 2017-06-20T07:27:20Z

meta-flatpak/recipes-flatpak/flatpak-utils/files/flatpak-utils/Makefile.am

+
+# This is the only way with automake I know of to force 'check-git-hooks'
+# to be evaluated before 'all'. If there is a nicer way, I'm all ears...
+BUILT_SOURCES = install-git-hooks


You don't need to install git hooks, if you have the source distribution inside the layer. There is no corresponding .git directory.

Ripped out githooks and removed associated rule.

ipuustin · 2017-06-20T07:44:38Z

meta-flatpak/recipes-flatpak/flatpak-utils/files/flatpak-utils/src/filesystem.c

+#include "flatpak-session.h"
+
+
+int fsys_prepare_session(context_t *c)


You anyway need to link against glib (you are using GError etc. in the flatpak interfacing code). Have you checked if you could just just glib file system functions (see https://developer.gnome.org/glib/stable/glib-File-Utilities.html)? That would reduce the amount of custom code we have to maintain.

Sure I could have used. glib has a g-wrapper for every imaginable POSIX filesystem-related system call and then some. It was an arbitrary but deliberate choice to use glib only where I have to, mostly for interfacing with libflatpak.

ipuustin · 2017-06-20T08:10:05Z

A README file for flatpak-utils would be nice. There are functions which are either dead code or used from somewhere I don't see, like fpak_app_systemd_scope. Also the restart logic is not fully clear. Is the whole daemon restarted when any flatpak app is updated? Or are you running one daemon for each app?

klihub · 2017-06-21T13:48:27Z

I've added a very brief README and removed the unused function.

The restart logic is that whenever anything changes (gets updated) in a session, the whole session gets restarted. The actual restart is delegated to systemd. When a restart is desired, the daemon exits with a special exit code reserved for this purpose which systemd is let know about in the service file. Systemd will then restart the daemon which will then relaunch the applications within the session. At least that's the general idea...

ipuustin · 2017-06-21T15:56:26Z

Great. Let's wait until testing is done. Is everything you want to include in this PR now in place?

klihub · 2017-06-21T18:10:21Z

Well, not quite yet. I need to still migrate some documentation over from the old repo. Also while I have added basic sanity tests, we still need to make sure they still work with latest meta-iotqa and CI infra. Once the tests work and the docs are in place, then I think this would be ready to go in.

klihub · 2017-06-21T18:55:46Z

Unfortunately running the tests for the flatpak-enabled gateway runtime image was not enabled at all. Fixed it. We'll have to check once the latest queued build is finished. Someone with supercow powers could show mercy on the currently running futile builds using the /stop REST API...

Signed-off-by: Krisztian Litkey <krisztian.litkey@intel.com>

Signed-off-by: Krisztian Litkey <kli@iki.fi>

klihub · 2017-06-22T12:13:49Z

The test were run and have passed. I've also the added initial documentation snippets about flatpak support.

Added recipe for flatpak-utils. Currently it only contains flatpak- session, our daemon to start up flatpak sessions, and the associated systemd generator. Also declared flatpak-utils as a supported recipe. Signed-off-by: Krisztian Litkey <krisztian.litkey@intel.com>

Added recipe for pre-declaring and populating the image with a set of pre-declared flatpak remotes/repositories and their associated flatpak-session users. These are then monitored for applications to automatically pull in/update and start in flatpak-sessions. Signed-off-by: Krisztian Litkey <krisztian.litkey@intel.com>

Added the necessary configuration bits for, and documented the whole process of, adding pre-declared remotes/repositories. Signed-off-by: Krisztian Litkey <krisztian.litkey@intel.com>

Added a flatpak-session packagegroup. It pulls in packagegroup-flatpak, flatpak-utils (for flatpak-session), and flatpak-predefined-repos. Signed-off-by: Krisztian Litkey <krisztian.litkey@intel.com>

Pull in packagegroup-flatpak-session if flatpak-session is among DISTRO_FEATURES. Signed-off-by: Krisztian Litkey <krisztian.litkey@intel.com>

…ons. If included/required, enable flatpak-session in DISTRO_FEATURES and also pull in basic flatpak support. Signed-off-by: Krisztian Litkey <krisztian.litkey@intel.com>

…gment. Added a commented out require for flatpak-session.inc and a comment about its purpose. Signed-off-by: Krisztian Litkey <krisztian.litkey@intel.com>

Signed-off-by: Krisztian Litkey <krisztian.litkey@intel.com>

klihub · 2017-06-22T19:14:45Z

teat this please

okartau · 2017-06-22T20:27:19Z

test this please (there needs to be 's' in 1st word :-)

klihub · 2017-06-23T07:33:37Z

Thanks! Oh boy, I hate touchscreens...

klihub · 2017-06-24T13:57:12Z

@ipuustin Now, this could go in. If we don't want to enable flatpak sessions by default, we should leave the config change commit out.

refkit-ci · 2017-06-24T19:48:11Z

Can one of the admins verify this patch?

This merge combines intel#191, intel#198, intel#199, and intel#207.

Arthil · 2017-06-27T07:27:05Z

Retest this please.

This merge combines intel#198, intel#199, intel#204, intel#205, and intel#207.

klihub force-pushed the flatpak-layer+flatpak-session branch 5 times, most recently from 732c776 to 12529fc Compare June 18, 2017 07:09

ipuustin reviewed Jun 19, 2017

View reviewed changes

ipuustin reviewed Jun 20, 2017

View reviewed changes

klihub force-pushed the flatpak-layer+flatpak-session branch from 12529fc to 9d5c3c5 Compare June 21, 2017 13:49

klihub force-pushed the flatpak-layer+flatpak-session branch 2 times, most recently from 93b275a to 369af92 Compare June 21, 2017 18:47

klihub force-pushed the flatpak-layer+flatpak-session branch from 369af92 to 4b7234a Compare June 22, 2017 12:12

klihub and others added 2 commits June 22, 2017 15:12

meta-iotqa: added minimal flatpak sanity test.

028a8e2

Signed-off-by: Krisztian Litkey <krisztian.litkey@intel.com>

refkit-ci.inc: run gateway flatpak runtime tests as well.

af5ead5

Signed-off-by: Krisztian Litkey <kli@iki.fi>

klihub added 7 commits June 22, 2017 15:14

layer.conf,flatpak-config.bbclass: handle pre-declared remotes/repos.

dbdafe9

Added the necessary configuration bits for, and documented the whole process of, adding pre-declared remotes/repositories. Signed-off-by: Krisztian Litkey <krisztian.litkey@intel.com>

packagegroups: added flatpak-session packagegroup.

7d536fc

Added a flatpak-session packagegroup. It pulls in packagegroup-flatpak, flatpak-utils (for flatpak-session), and flatpak-predefined-repos. Signed-off-by: Krisztian Litkey <krisztian.litkey@intel.com>

flatpak-image-variants.bbclass: conditional support for flatpak-session.

9e8c66f

Pull in packagegroup-flatpak-session if flatpak-session is among DISTRO_FEATURES. Signed-off-by: Krisztian Litkey <krisztian.litkey@intel.com>

flatpak-session.inc: added config fragment for enabling flatpak sessi…

ffbdacf

…ons. If included/required, enable flatpak-session in DISTRO_FEATURES and also pull in basic flatpak support. Signed-off-by: Krisztian Litkey <krisztian.litkey@intel.com>

enable-refkit-config.inc: require (commented out) flatpak-session fra…

a768a65

…gment. Added a commented out require for flatpak-session.inc and a comment about its purpose. Signed-off-by: Krisztian Litkey <krisztian.litkey@intel.com>

klihub and others added 3 commits June 22, 2017 15:14

meta-iotqa: added minimal flatpak-session sanity test.

09cc2e4

Signed-off-by: Krisztian Litkey <krisztian.litkey@intel.com>

doc: initial documentation about flatpak support.

89d51aa

Signed-off-by: Krisztian Litkey <krisztian.litkey@intel.com>

test config change: enable flatpak-session support.

2c64cce

klihub force-pushed the flatpak-layer+flatpak-session branch from 4b7234a to 2c64cce Compare June 22, 2017 12:17

mythi added a commit to mythi/intel-iot-refkit that referenced this pull request Jun 27, 2017

Merge multiple PRs

3a66a4e

This merge combines intel#191, intel#198, intel#199, and intel#207.

mythi added a commit to mythi/intel-iot-refkit that referenced this pull request Jun 27, 2017

Merge multiple PRs

63001b4

This merge combines intel#198, intel#199, intel#204, intel#205, and intel#207.

mythi merged commit 2c64cce into intel:master Jun 27, 2017

klihub deleted the flatpak-layer+flatpak-session branch August 21, 2017 12:15

		#include "flatpak-session.h"


		int fsys_prepare_session(context_t *c)

Flatpak session (a.k.a. flatpak-based app fw) support. #198

Flatpak session (a.k.a. flatpak-based app fw) support. #198

Uh oh!

Conversation

klihub commented Jun 16, 2017

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

klihub Jun 21, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ipuustin commented Jun 20, 2017

Uh oh!

klihub commented Jun 21, 2017

Uh oh!

ipuustin commented Jun 21, 2017

Uh oh!

klihub commented Jun 21, 2017

Uh oh!

klihub commented Jun 21, 2017

Uh oh!

klihub commented Jun 22, 2017

Uh oh!

klihub commented Jun 22, 2017

Uh oh!

okartau commented Jun 22, 2017

Uh oh!

klihub commented Jun 23, 2017

Uh oh!

klihub commented Jun 24, 2017

Uh oh!

refkit-ci commented Jun 24, 2017

Uh oh!

Arthil commented Jun 27, 2017

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

klihub Jun 21, 2017 •

edited

Loading