Skip to content
This repository was archived by the owner on Aug 5, 2022. It is now read-only.

Conversation

@okartau
Copy link
Contributor

@okartau okartau commented Jun 22, 2017

  1. Cleanup of older build trees was not reliable.
    Cleaning should run in early stage (using parallel stmt to avoid blocking other activity).
    Previous way, running it later in parallel with on-device testing created 2 problems:
  • in case of queued runs, same slot got busy with another job before cleaning thread,
    which caused dummy wait of current job by length on another, newly started job:
  • in case of failure during post-build, cleanup was not run at all,
    which risked filling builder disks after repeated failures on same node.

Signed-off-by: Olev Kartau olev.kartau@intel.com

@okartau okartau force-pushed the move-cleanup-to-start branch 4 times, most recently from b04a548 to 9e409c9 Compare June 22, 2017 21:15
@okartau okartau changed the title CI Jenkinsfile: move cleanup closer to job main part CI Jenkinsfile: move cleanup into job main part Jun 22, 2017
@okartau okartau force-pushed the move-cleanup-to-start branch 2 times, most recently from 26aab41 to f5b44e9 Compare June 25, 2017 12:02
@okartau okartau force-pushed the move-cleanup-to-start branch 2 times, most recently from fd73ebf to 38785bf Compare June 26, 2017 10:16
@okartau okartau force-pushed the move-cleanup-to-start branch from 38785bf to 202720c Compare June 26, 2017 10:56
@okartau okartau changed the title CI Jenkinsfile: move cleanup into job main part CI: fixes and improvements Jun 26, 2017
@okartau okartau force-pushed the move-cleanup-to-start branch from 202720c to 90f58f6 Compare June 27, 2017 09:08
@okartau okartau changed the title CI: fixes and improvements CI: fix cleanup of older build directories Jun 27, 2017
mythi added a commit to mythi/intel-iot-refkit that referenced this pull request Jun 27, 2017
Deletion of older builds is more reliable as part of main stage.
Running it later during on-device testers created problems:
 - in case of queued runs, same worker started another job before
   cleaning thread started, delaying completion by length of new job;
 - in case of failure during post-build, cleanup did not run at all;

Signed-off-by: Olev Kartau <olev.kartau@intel.com>
@okartau okartau force-pushed the move-cleanup-to-start branch from 90f58f6 to 23db97e Compare June 27, 2017 15:40
@mythi mythi merged commit 4362586 into intel:master Jun 27, 2017
@okartau okartau deleted the move-cleanup-to-start branch July 6, 2017 12:43
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants