test enhancements #199
test enhancements #199
Conversation
|
@ipuustin this is something we should be able to merge quickly, once testing is done. |
|
Looks good to me. Let's merge this when the tests pass. |
|
For some reason the |
|
On Tue, 2017-06-20 at 01:14 -0700, Ismo Puustinen wrote:
For some reason the common image mraa/upm tests didn't pass. ;-) Could
you move them to use the gateway image?
I don't know how that part of testing works. Someone else will have to
resolve this.
I had a quick look and I see that meta-iotqa/classes/test-iot.bbclass
apparently installs the failing binaries - to all images?! That wouldn't
make sense or would have to be changed, as it might pull in unwanted
content into refkit-image-common (although in this case, some shared
libraries end up as missing):
https://ostroproject.org/jenkins/job/intel-iot-refkit_pull-requests/1589/testReport/junit/qemu.refkit-image-common.oeqa.runtime.peripherals.upm.upm/UpmTest/test_upm_import/
/opt/upm-test/upm_test: error while loading shared libraries:
libupmc-utilities.so.1: cannot open shared object file: No such file or
directory
@mythi: as you suggested that mraa/upm/nodejs shouldn't be in
refkit-image-common, can you make sure that this gets worked on by QA or
someone?
|
|
@pohly Hey, like @ipuustin said, you can modify which tests are run in the manifest files located in https://github.com/intel/intel-iot-refkit/tree/master/meta-iotqa/conf/test . Also note that all the tests in refkit-image-common.manifest are also run on computervision and gateway profiles. If you want to have these particular test only in gateway, you can remove them from refkit-image-common.manifest and add them to gateway instead. |
|
On Tue, 2017-06-20 at 03:38 -0700, Christian da Costa wrote:
@pohly Hey, like @ipuustin said, you can modify which tests are run in
the manifest files located in
https://github.com/intel/intel-iot-refkit/tree/master/meta-iotqa/conf/test . Also note that test in refkit-image-common.manifest are also run on computervision and gateway profiles. If you want to have these particular test only in gateway, you can remove them from refkit-image-common.manifest and add them to gateway instead.
That changes which tests get run.
But how do I prevent mraa-test from getting installed into
refkit-image-common? It doesn't belong there.
|
|
@pohly: try removing mraa-test from |
|
Can one of the admins verify this patch? |
The "sensors" image feature includes mraa, upm and via their dependencies also NodeJS. This is not required by all profiles and having it in common has some downsides: - slower build times in all tests using refkit-image-common (but not much, at least when NodeJS is already built, only 17s less when building twice, which takes several minutes) - dependency on components which are not in OE-core and thus have a higher chance of breaking in other distros Tests needs to be moved from common to gateway, too. While at it, sorting order gets restored in the gateway test list. Signed-off-by: Patrick Ohly <patrick.ohly@intel.com>
This has two advantages: - slightly faster (but not much) - less annoying when run on a developer desktop, because the graphical console window tends to pop up randomly during testing Signed-off-by: Patrick Ohly <patrick.ohly@intel.com>
|
I'm not sure, but it looks like mraa-tests only gets installed during testing. So perhaps changing the manifests is really all that's needed. Let's see whether it passes now. |
|
@mythi it passed testing now, so probably ready for merging. |
5 participants
Nothing major, just the removal of mraa/upm/NodeJS from
refkit-image-common that Mikko proposed in PR #184 and another
enhancement that I found useful.