enhance some security check #880
Merged
XinfengZhang merged 2 commits intointel:masterfrom Apr 23, 2026
Merged
Conversation
Add a null-pointer check for the display parameter at the entry of vaGetDisplayWl(), returning NULL immediately instead of proceeding to backend initialization which would crash with a null dereference. This aligns the Wayland constructor with the X11 and DRM constructors which already validate their native display/fd arguments early. Signed-off-by: Carl.Zhang <carl.zhang@intel.com>
Add CHECK_DISPLAY(dpy) before CTX(dpy) to validate the display handle, and add a NULL check for driver_name before calling strlen(). Without these guards, passing NULL for either argument causes a null-pointer dereference instead of returning a proper error status. This aligns vaSetDriverName() with the validation pattern used by other public APIs in va.c. Signed-off-by: Carl.Zhang <carl.zhang@intel.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.