[SYCL][DOC] Represent cache level by enum instead of int #11366
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: James Brodman <james.brodman@intel.com>
gmlueck
reviewed
Sep 29, 2023
sycl/doc/extensions/proposed/sycl_ext_intel_cache_controls.asciidoc
Outdated
Show resolved
Hide resolved
sycl/doc/extensions/proposed/sycl_ext_intel_cache_controls.asciidoc
Outdated
Show resolved
Hide resolved
…iidoc Co-authored-by: Greg Lueck <gregory.m.lueck@intel.com>
…iidoc Co-authored-by: Greg Lueck <gregory.m.lueck@intel.com>
gmlueck
approved these changes
Oct 5, 2023
rdeodhar
reviewed
Oct 12, 2023
Contributor
rdeodhar
left a comment
rdeodhar
left a comment
There was a problem hiding this comment.
Using an enum is a good idea. The implementation is under way and the doc will be updated with some changes and put up for review along with the implementation (using an enum).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the extension to represent cache levels as an enum instead of an integer.