Skip to content

[SYCL][DOC] Represent cache level by enum instead of int #11366

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bader merged 3 commits into from
Oct 12, 2023
Merged

[SYCL][DOC] Represent cache level by enum instead of int #11366

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5507107
Represent cache level by enum instead of int
jbrodman Sep 29, 2023
ec12bb3
Update sycl/doc/extensions/proposed/sycl_ext_intel_cache_controls.asc…
jbrodman Oct 4, 2023
324e4ee
Update sycl/doc/extensions/proposed/sycl_ext_intel_cache_controls.asc…
jbrodman Oct 4, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
37 changes: 22 additions & 15 deletions sycl/doc/extensions/proposed/sycl_ext_intel_cache_controls.asciidoc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,6 +98,13 @@ Below is a list of new compile-time constant properties supported with
```c++
namespace sycl::ext::intel::experimental {

enum class cache_level : /*unspecified*/ {
L1,
L2,
L3,
L4,
};

enum class cache_control_read_type : /* unspecified */ {
cached,
uncached,
Expand All @@ -114,19 +121,19 @@ enum class cache_control_write_type : /* unspecified */ {
};

struct cache_control_read_key {
template<cache_control_read_type C, int L>
using value_t = property_value<cache_control_read, C, std::integral_constant<int, L>>;
template<cache_control_read_type C, cache_level L>
using value_t = property_value<cache_control_read, C, std::integral_constant<cache_level, L>>;
};

struct cache_control_write_key {
template<cache_control_write_type C, int L>
using value_t = property_value<cache_control_write, C, std::integral_constant<int, L>>;
template<cache_control_write_type C, cache_level L>
using value_t = property_value<cache_control_write, C, std::integral_constant<cache_level, L>>;
};

template<cache_control_read_type C, int L>
template<cache_control_read_type C, cache_level L>
inline constexpr cache_control_read_key::value_t<C, L> cache_control_read;

template<cache_control_write_type C, int L>
template<cache_control_write_type C, cache_level L>
inline constexpr cache_control_write_key::value_t<C, L> cache_control_write;

template<>
Expand All @@ -143,32 +150,32 @@ template<typename T, typename PropertyListT>
struct is_property_key_of<
cache_control_write_key, annotated_ptr<T, PropertyListT>> : std::true_type {};

template<int L>
template<cache_level L>
inline constexpr cache_control_read_key::value_t<cache_control_read_type::cached, L>
cache_control_read_cached;

template<int L>
template<cache_level L>
inline constexpr cache_control_read_key::value_t<cache_control_read_type::uncached, L> cache_control_read_uncached;

template<int L>
template<cache_level L>
inline constexpr cache_control_read_key::value_t<cache_control_read_type::streaming, L> cache_control_read_streaming;

template<int L>
template<cache_level L>
inline constexpr cache_control_read_key::value_t<cache_control_read_type::invalidate_after_read, L> cache_control_invalidate_after_read;

template<int L>
template<cache_level L>
inline constexpr cache_control_read_key::value_t<cache_control_read_type::const_cached, L> cache_control_read_const_cached;

template<int L>
template<cache_level L>
inline constexpr cache_control_write_key::value_t<cache_control_write_type::uncached, L> cache_control_write_uncached;

template<int L>
template<cache_level L>
inline constexpr cache_control_write_key::value_t<cache_control_write_type::write_streaming, L> cache_control_write_streaming;

template<int L>
template<cache_level L>
inline constexpr cache_control_write_key::value_t<cache_control_write_type::write_through, L> cache_control_write_through;

template<int L>
template<cache_level L>
inline constexpr cache_control_write_key::value_t<cache_control_write_type::write_back, L> cache_control_write_back;

} // namespace sycl::ext::intel::experimental
Expand Down