[SYCL] Replace CUDA & HIP features.hpp headers with macros #14667
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kbenzie
changed the title
kbenzie
force-pushed
the
benie/pi2ur-feature-tests
branch
from
240d034 to
06e1bdf
Compare
Split out from intel#14145 this patch replaces the generated `features.hpp` header for the CUDA and HIP plugins, which only defined single feature test macro, with `#cmakedefine01` definitions controlled by the build system.
kbenzie
force-pushed
the
benie/pi2ur-feature-tests
branch
from
06e1bdf to
81286c9
Compare
AlexeySachkov
approved these changes
Jul 23, 2024
Contributor
Author
|
@uditagarwal97 anything needing changed or is this in a good state for apporoval? |
keryell
reviewed
Jul 25, 2024
| endif() | ||
| if ("level_zero" IN_LIST SYCL_ENABLE_PLUGINS) | ||
| set(SYCL_BUILD_PI_LEVEL_ZERO ON) | ||
| set(SYCL_BUILD_BACKENDLEVEL_ZERO ON) |
Contributor
There was a problem hiding this comment.
SYCL_BUILD_BACKEND_LEVEL_ZERO
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Split out from #14145 this patch replaces the generated
features.hppheader for the CUDA and HIP plugins, which only defined single feature test macro, with#cmakedefine01definitions controlled by the build system.