[SYCL] Also check for use of SYCL_PI_TRACE on Linux #15113
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As part of removing the plugin interface a check was added for the use of the `SYCL_PI_TRACE` environment variable. However, this was only applied on the Windows path. This patch moves this check to a common path for both Windows and Linux.
martygrant
approved these changes
Aug 16, 2024
omarahmed1111
approved these changes
Aug 16, 2024
RossBrunton
approved these changes
Aug 16, 2024
againull
approved these changes
Aug 16, 2024
| // std::call_once is blocking all other threads if a thread is already | ||
| // creating a vector of plugins. So, no additional lock is needed. | ||
| std::call_once(PluginsInitDone, [&]() { | ||
| // TODO: Remove this SYCL_PI_TRACE notification in the first patch release |
Contributor
There was a problem hiding this comment.
Note that this is a functional change for which we have no test so it will be easy to accidentally drop/break this diagnostics
AlexeySachkov
pushed a commit
to AlexeySachkov/llvm
that referenced
this pull request
Nov 26, 2024
As part of removing the plugin interface a check was added for the use of the `SYCL_PI_TRACE` environment variable. However, this was only applied on the Windows path. This patch moves this check to a common path for both Windows and Linux.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As part of removing the plugin interface a check was added for the use of the
SYCL_PI_TRACEenvironment variable. However, this was only applied on the Windows path. This patch moves this check to a common path for both Windows and Linux.