Skip to content

[SYCL] Also check for use of SYCL_PI_TRACE on Linux #15113

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 16, 2024
Merged

[SYCL] Also check for use of SYCL_PI_TRACE on Linux #15113

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 0 additions & 7 deletions sycl/source/detail/global_handler.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -355,13 +355,6 @@ void shutdown_late() {
extern "C" __SYCL_EXPORT BOOL WINAPI DllMain(HINSTANCE hinstDLL,
DWORD fdwReason,
LPVOID lpReserved) {
// TODO: Remove from public header files and implementation during the next
// ABI Breaking window.
if (std::getenv("SYCL_PI_TRACE")) {
std::cerr << "SYCL_PI_TRACE has been removed use SYCL_UR_TRACE instead\n";
std::exit(1);
}

bool PrintUrTrace =
sycl::detail::ur::trace(sycl::detail::ur::TraceLevel::TRACE_CALLS);

Expand Down
7 changes: 7 additions & 0 deletions sycl/source/detail/ur.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,6 +91,13 @@ std::vector<PluginPtr> &initializeUr(ur_loader_config_handle_t LoaderConfig) {
// std::call_once is blocking all other threads if a thread is already
// creating a vector of plugins. So, no additional lock is needed.
std::call_once(PluginsInitDone, [&]() {
// TODO: Remove this SYCL_PI_TRACE notification in the first patch release
Copy link
Contributor

@AlexeySachkov AlexeySachkov Sep 2, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note that this is a functional change for which we have no test so it will be easy to accidentally drop/break this diagnostics

// after the next ABI breaking window.
if (std::getenv("SYCL_PI_TRACE")) {
std::cerr << "SYCL_PI_TRACE has been removed use SYCL_UR_TRACE instead\n";
std::exit(1);
}

initializePlugins(GlobalHandler::instance().getPlugins(), LoaderConfig);
});
return GlobalHandler::instance().getPlugins();
Expand Down