[SYCL] Fix segmentation fault that occurs when creating host accessors in parallel#1597
Merged
bader merged 4 commits intoApr 29, 2020
Merged
[SYCL] Fix segmentation fault that occurs when creating host accessors in parallel#1597bader merged 4 commits into
bader merged 4 commits into
Conversation
…s in parallel Signed-off-by: Dmitry Vodopyanov <dmitry.vodopyanov@intel.com>
Signed-off-by: Dmitry Vodopyanov <dmitry.vodopyanov@intel.com>
s-kanaev
reviewed
Apr 28, 2020
Signed-off-by: Dmitry Vodopyanov <dmitry.vodopyanov@intel.com>
s-kanaev
reviewed
Apr 28, 2020
keryell
reviewed
Apr 29, 2020
Contributor
keryell
left a comment
keryell
left a comment
There was a problem hiding this comment.
It is not clear why it happens.
Is it because you are looking to late and release too early?
I do not remember this issue in triSYCL, even if there are currently some other problems.
Signed-off-by: Dmitry Vodopyanov <dmitry.vodopyanov@intel.com>
Contributor
Author
|
@keryell correct, this is typical data race caused by accessing data by one thread which was already released by another thread. Segmentation fault was happened on line 508 of cl_int Res = enqueueImp(); |
sergey-semenov
approved these changes
Apr 29, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Dmitry Vodopyanov dmitry.vodopyanov@intel.com