-
Notifications
You must be signed in to change notification settings - Fork 796
[SYCL] Fix complex support for Cuda/HIP #18667
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d177576 to
5a908cd
Compare
Contributor
Author
|
cc: @npmiller |
5a908cd to
5190142
Compare
maarquitos14
approved these changes
May 27, 2025
Contributor
maarquitos14
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
npmiller
approved these changes
May 27, 2025
Contributor
Author
|
All the failures are from graph tests on Intel device and are not related to this patch. |
Contributor
Author
|
Failures are now tracked in: #18668 |
Contributor
Author
|
@intel/llvm-gatekeepers this should be ready to roll, thank you. |
5190142 to
054b120
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The implementation was incorrectly kept behind SPIR-V ifdefs.