Skip to content

Conversation

@jchlanda
Copy link
Contributor

@jchlanda jchlanda commented May 26, 2025

The implementation was incorrectly kept behind SPIR-V ifdefs.

@jchlanda jchlanda temporarily deployed to WindowsCILock May 26, 2025 13:23 — with GitHub Actions Inactive
@jchlanda jchlanda temporarily deployed to WindowsCILock May 26, 2025 14:06 — with GitHub Actions Inactive
@jchlanda jchlanda temporarily deployed to WindowsCILock May 26, 2025 14:06 — with GitHub Actions Inactive
@jchlanda jchlanda force-pushed the jakub/complex_gpu branch from d177576 to 5a908cd Compare May 27, 2025 06:00
@jchlanda jchlanda temporarily deployed to WindowsCILock May 27, 2025 06:01 — with GitHub Actions Inactive
@jchlanda jchlanda marked this pull request as ready for review May 27, 2025 06:02
@jchlanda jchlanda requested a review from a team as a code owner May 27, 2025 06:02
@jchlanda jchlanda requested a review from maarquitos14 May 27, 2025 06:02
@jchlanda
Copy link
Contributor Author

cc: @npmiller

Copy link
Contributor

@maarquitos14 maarquitos14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jchlanda
Copy link
Contributor Author

All the failures are from graph tests on Intel device and are not related to this patch.

@jchlanda
Copy link
Contributor Author

Failures are now tracked in: #18668

@jchlanda
Copy link
Contributor Author

@intel/llvm-gatekeepers this should be ready to roll, thank you.

@jchlanda jchlanda force-pushed the jakub/complex_gpu branch from 5190142 to 054b120 Compare May 27, 2025 10:27
@jchlanda jchlanda temporarily deployed to WindowsCILock May 27, 2025 10:27 — with GitHub Actions Inactive
@jchlanda jchlanda temporarily deployed to WindowsCILock May 27, 2025 11:03 — with GitHub Actions Inactive
@jchlanda jchlanda temporarily deployed to WindowsCILock May 27, 2025 11:03 — with GitHub Actions Inactive
@ldrumm ldrumm merged commit 4157f90 into intel:sycl May 27, 2025
36 of 37 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants