Skip to content

[SYCL] Fix complex support for Cuda/HIP #18667

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 27, 2025
Merged

[SYCL] Fix complex support for Cuda/HIP #18667

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion libdevice/complex_wrapper.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,8 @@

#include "device_complex.h"

#if defined(__SPIR__) || defined(__SPIRV__)
#if defined(__SPIR__) || defined(__SPIRV__) || defined(__NVPTX__) || \
defined(__AMDGCN__)

DEVICE_EXTERN_C_INLINE
float cimagf(float __complex__ z) { return __devicelib_cimagf(z); }
Expand Down
3 changes: 2 additions & 1 deletion libdevice/complex_wrapper_fp64.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,8 @@

#include "device_complex.h"

#if defined(__SPIR__) || defined(__SPIRV__)
#if defined(__SPIR__) || defined(__SPIRV__) || defined(__NVPTX__) || \
defined(__AMDGCN__)

DEVICE_EXTERN_C_INLINE
double cimag(double __complex__ z) { return __devicelib_cimag(z); }
Expand Down
3 changes: 2 additions & 1 deletion libdevice/device_complex.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,8 @@

#include "device.h"

#if defined(__SPIR__) || defined(__SPIRV__)
#if defined(__SPIR__) || defined(__SPIRV__) || defined(__NVPTX__) || \
defined(__AMDGCN__)

// TODO: This needs to be more robust.
// clang doesn't recognize the c11 CMPLX macro, but it does have
Expand Down
3 changes: 2 additions & 1 deletion libdevice/fallback-complex-fp64.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,8 @@

#include "device_complex.h"

#if defined(__SPIR__) || defined(__SPIRV__)
#if defined(__SPIR__) || defined(__SPIRV__) || defined(__NVPTX__) || \
defined(__AMDGCN__)
#include <cmath>

// To support fallback device libraries on-demand loading, please update the
Expand Down
3 changes: 2 additions & 1 deletion libdevice/fallback-complex.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,8 @@

#include "device_complex.h"

#if defined(__SPIR__) || defined(__SPIRV__)
#if defined(__SPIR__) || defined(__SPIRV__) || defined(__NVPTX__) || \
defined(__AMDGCN__)
#include <cmath>

// To support fallback device libraries on-demand loading, please update the
Expand Down
1 change: 0 additions & 1 deletion sycl/test-e2e/DeviceLib/std_complex_math_fp64_test.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
// REQUIRES: aspect-fp64
// UNSUPPORTED: target-amd || target-nvidia
// XFAIL: windows && arch-intel_gpu_bmg_g21
// XFAIL-TRACKER: https://github.com/intel/llvm/issues/17165
// RUN: %{build} -o %t1.out
Expand Down
1 change: 0 additions & 1 deletion sycl/test-e2e/DeviceLib/std_complex_math_test.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
// DEFINE: %{mathflags} = %if cl_options %{/clang:-fno-fast-math%} %else %{-fno-fast-math%}
// UNSUPPORTED: target-amd || target-nvidia
// RUN: %{build} %{mathflags} -o %t1.out
// RUN: %{run} %t1.out

Expand Down
4 changes: 1 addition & 3 deletions sycl/test/e2e_test_requirements/no-unsupported-without-info.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@
// tests to match the required format and in that case you should just update
// (i.e. reduce) the number and the list below.
//
// NUMBER-OF-UNSUPPORTED-WITHOUT-INFO: 257
// NUMBER-OF-UNSUPPORTED-WITHOUT-INFO: 255
//
// List of improperly UNSUPPORTED tests.
// Remove the CHECK once the test has been properly UNSUPPORTED.
Expand Down Expand Up @@ -117,8 +117,6 @@
// CHECK-NEXT: DeviceLib/imf_simd_emulate_test.cpp
// CHECK-NEXT: DeviceLib/rand_test.cpp
// CHECK-NEXT: DeviceLib/separate_compile_test.cpp
// CHECK-NEXT: DeviceLib/std_complex_math_fp64_test.cpp
// CHECK-NEXT: DeviceLib/std_complex_math_test.cpp
// CHECK-NEXT: ESIMD/PerformanceTests/BitonicSortK.cpp
// CHECK-NEXT: ESIMD/PerformanceTests/BitonicSortKv2.cpp
// CHECK-NEXT: ESIMD/PerformanceTests/Stencil.cpp
Expand Down