[SYCL][Doc] Specify that invalid host_access_enum values are ill-formed#21445
Merged
sarnex merged 1 commit intoMar 4, 2026
Merged
Conversation
Currently code like this is accepted by DPC++: ```cpp device_global<int, decltype(host_access_key::value_t<static_cast<host_access_enum>(42)>)> var; ``` and results in the generated SPIR-V with a `HostAccess` property set to 42, which is not a valid value. In another change I'm looking to make this an error in some *but not all* cases, but nothing in the spec currently prohibits this code in my reading. Add a sentence to make it ill-formed, no diagnostic required. We could make it a required hard error, but that is surprisingly difficult to implement for little benefit: in practice I don't expect any users to be doing this.
sarnex
approved these changes
Mar 4, 2026
sarnex
left a comment
sarnex
left a comment
Contributor
There was a problem hiding this comment.
lgtm from doc pov, will leave to spec reivewers for correctness
Contributor
|
@intel/llvm-gatekeepers please consider merging |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently code like this is accepted by DPC++:
and results in the generated SPIR-V with a
HostAccessproperty set to 42, which is not a valid value.In another change I'm looking to make this an error in some but not all, cases, but nothing in the spec currently prohibits this code in my reading.
Add a sentence to make it ill-formed, no diagnostic required. We could make it a required hard error, but that is surprisingly difficult to implement for little benefit: in practice I don't expect any users to be actually doing this.