[SYCL][NewOffloadModel] add support of -no-sycl-rdc in clang-linker-wrapper#22118
Merged
sarnex merged 8 commits intoJul 1, 2026
Merged
Conversation
maksimsab
force-pushed
the
sycl-no-rdc-new-offload/clang-linker-wrapper-change
branch
from
c8fc91d to
19d314d
Compare
maksimsab
force-pushed
the
sycl-no-rdc-new-offload/clang-linker-wrapper-change
branch
from
19d314d to
d6e538b
Compare
maksimsab
changed the title
YuriPlyakhin
left a comment
YuriPlyakhin
left a comment
Contributor
There was a problem hiding this comment.
@maksimsab , is this PR ready for review?
I'm asking because there are quite a few tests failing - are those fails related?
Contributor
Author
|
RHEL compilation failure is addressed. |
sarnex
reviewed
Jun 23, 2026
| return LinkedModuleOrErr.takeError(); | ||
| // Note: pipeline can skip linking due to -fno-sycl-rdc option. | ||
| // In that case, we apply sycl processing to several modules. | ||
| std::vector<StringRef> Modules; |
Contributor
There was a problem hiding this comment.
Is this the only change required for -fno-sycl-rdc support in the new offload model? Or are Clang driver changes also required?
Contributor
Author
There was a problem hiding this comment.
There will be one more patch in Clang Driver that sets this options for clang-linker-wrapper.
sarnex
reviewed
Jun 24, 2026
sarnex
approved these changes
Jun 29, 2026
Contributor
Author
|
Hi @intel/dpcpp-clang-driver-reviewers ! |
mdtoguchi
approved these changes
Jun 30, 2026
sarnex
reviewed
Jun 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.