Skip to content

[CI][Bench] Use UR's shared lib loader#22126

Merged
kswiecicki merged 7 commits into
syclfrom
lstolarc-fix-bench-ur-static
May 28, 2026
Merged

[CI][Bench] Use UR's shared lib loader#22126
kswiecicki merged 7 commits into
syclfrom
lstolarc-fix-bench-ur-static

Conversation

@lukaszstolarczuk

Copy link
Copy Markdown
Contributor

for compute-benchmarks to work properly - they link to UR loader, and when it's static it misses links to ur_common and xpti.

ref. #22031

@lukaszstolarczuk lukaszstolarczuk requested a review from a team as a code owner May 27, 2026 10:28
@lukaszstolarczuk

lukaszstolarczuk commented May 27, 2026

Copy link
Copy Markdown
Contributor Author

@lukaszstolarczuk

Copy link
Copy Markdown
Contributor Author

FYI, ping @pbalcer

@lukaszstolarczuk lukaszstolarczuk marked this pull request as draft May 27, 2026 11:19
@lukaszstolarczuk

Copy link
Copy Markdown
Contributor Author

och... the per-PR bench job does not build its own SYCL, it uses pre-built one from nightly image. I have to figure it out. Changing to draft for now.

@lukaszstolarczuk lukaszstolarczuk force-pushed the lstolarc-fix-bench-ur-static branch from 6440202 to 3fb7429 Compare May 27, 2026 14:33
for compute-benchmarks to work properly - they link to UR loader,
and when it's static it misses links to ur_common and xpti.

ref. #22031
@lukaszstolarczuk lukaszstolarczuk force-pushed the lstolarc-fix-bench-ur-static branch from b94df3b to 55bb76d Compare May 28, 2026 10:19
@lukaszstolarczuk lukaszstolarczuk marked this pull request as ready for review May 28, 2026 10:20
Comment thread devops/actions/run-tests/benchmark/action.yml Outdated
Comment thread .github/workflows/sycl-ur-perf-benchmarking.yml
@sys-ce-bb

Copy link
Copy Markdown
Contributor

@intel/llvm-gatekeepers please consider merging

@kswiecicki kswiecicki merged commit 45de37b into sycl May 28, 2026
16 checks passed
@kswiecicki kswiecicki deleted the lstolarc-fix-bench-ur-static branch May 28, 2026 11:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants