Skip to content

[CI][Bench] Use UR's shared lib loader #22126

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kswiecicki merged 7 commits into from
May 28, 2026
Merged

[CI][Bench] Use UR's shared lib loader #22126

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
6ad8c6b
[CI][Bench] Use UR's shared lib loader
lukaszstolarczuk May 27, 2026
13defdd
[CI][Bench] Fix per-PR job by adding custom SYCL build
lukaszstolarczuk May 27, 2026
c408861
test CI
lukaszstolarczuk May 27, 2026
3d0384d
fix build
lukaszstolarczuk May 28, 2026
a134f9e
fix build 2
lukaszstolarczuk May 28, 2026
55bb76d
cleanup
lukaszstolarczuk May 28, 2026
b8319f1
review fixes
lukaszstolarczuk May 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 25 additions & 4 deletions .github/workflows/sycl-ur-perf-benchmarking.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -184,7 +184,7 @@ jobs:
build_ref: ${{ needs.sanitize_inputs_dispatch.outputs.build_ref }}
build_cache_root: "/__w/"
build_cache_suffix: "prod_noassert"
build_configure_extra_args: "--no-assertions"
build_configure_extra_args: "--no-assertions --cmake-opt='-DUR_STATIC_LOADER=OFF'"
build_image: "ghcr.io/intel/llvm/sycl_ubuntu2404_nightly:latest"
changes: '[]'
toolchain_artifact: sycl_linux_prod_noassert
Expand Down Expand Up @@ -231,7 +231,7 @@ jobs:
with:
build_cache_root: "/__w/"
build_cache_suffix: "prod_noassert"
build_configure_extra_args: '--no-assertions'
build_configure_extra_args: '--no-assertions --cmake-opt="-DUR_STATIC_LOADER=OFF"'
build_image: ghcr.io/intel/llvm/sycl_ubuntu2404_nightly:latest
changes: '[]'
toolchain_artifact: sycl_linux_prod_noassert
Expand Down Expand Up @@ -270,13 +270,31 @@ jobs:
toolchain_decompress_command: ${{ needs.build_nightly.outputs.toolchain_decompress_command }}
# END nightly benchmarking path

# BEGIN benchmark framework builds and runs on PRs path
# BEGIN benchmark framework builds and runs on PRs path:
#
# Note: we needed to add custom SYCL build, instead of using the nightly build (from docker),
# because we need shared ur_loader library, instead of default static one.
# There's an issue in linking with other static libraries in CB build.
#
build_test:
Comment thread
PatKamin marked this conversation as resolved.
name: '[PR] Build SYCL'
if: ${{ github.repository == 'intel/llvm' && (github.event_name == 'pull_request' && inputs.trigger_nightly != 'true') }}
uses: ./.github/workflows/sycl-linux-build.yml
with:
build_cache_root: "/__w/"
build_cache_suffix: "prod_noassert"
build_configure_extra_args: '--no-assertions --cmake-opt="-DUR_STATIC_LOADER=OFF"'
build_image: ghcr.io/intel/llvm/sycl_ubuntu2404_nightly:latest
changes: '[]'
toolchain_artifact: sycl_linux_prod_noassert

test_benchmark_framework:
name: '[PR] Benchmark suite testing'
needs: [build_test]
permissions:
contents: write
packages: read
if: github.event_name == 'pull_request'
if: ${{ !cancelled() && needs.build_test.outputs.build_conclusion == 'success' }}
uses: ./.github/workflows/sycl-linux-run-tests.yml
with:
name: 'Framework test only: L0, Minimal preset, dry-run'
Expand All @@ -290,4 +308,7 @@ jobs:
benchmark_dry_run: true
benchmark_exit_on_failure: true
repo_ref: ${{ github.sha }}
toolchain_artifact: ${{ needs.build_test.outputs.toolchain_artifact }}
toolchain_artifact_filename: ${{ needs.build_test.outputs.toolchain_artifact_filename }}
toolchain_decompress_command: ${{ needs.build_test.outputs.toolchain_decompress_command }}
# END benchmark framework builds and runs on PRs path
5 changes: 2 additions & 3 deletions devops/actions/run-tests/benchmark/action.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -133,8 +133,7 @@ runs:

# Check if SYCL dir exists and has SYCL lib; set CMPLR_ROOT if so
if [ -d "$SYCL_DIR" ] && [ -f "$SYCL_DIR/lib/libsycl.so" ]; then
echo "Using SYCL from: $SYCL_DIR"
export CMPLR_ROOT=$SYCL_DIR
export CMPLR_ROOT=$(realpath "$SYCL_DIR")
echo "CMPLR_ROOT=$CMPLR_ROOT" >> $GITHUB_ENV

# Set timestamp based on the compiler library's time.
Expand All @@ -147,9 +146,9 @@ runs:
which sycl-ls
sycl-ls
export CMPLR_ROOT="$(dirname $(dirname $(which sycl-ls)))"
echo "Using SYCL from: $CMPLR_ROOT !"
echo "CMPLR_ROOT=$CMPLR_ROOT" >> $GITHUB_ENV
fi
echo "Using SYCL from: $CMPLR_ROOT"

if [ -z "$SAVE_TIMESTAMP" ]; then
export SAVE_TIMESTAMP="$(date -u +'%Y%m%d_%H%M%S')" # Current timestamp in UTC time
Expand Down
Loading