[SYCL] Print default arguments of templates when printing kernel names for lambdas/functors in integration header#22339
Merged
Merged
Conversation
…ambdas/functors in integration header
Contributor
Author
|
only @intel/dpcpp-cfe-reviewers is needed for review here. The commit history contains some runtime changes which is why the runtime team has also been pinged for review but in this particular PR, there are no runtime changes with respect to the sycl branch of upstream. |
Contributor
|
@intel/llvm-gatekeepers please consider merging |
Contributor
Author
Yes, this should be good to go for merge @intel/llvm-gatekeepers |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR enables the printing of all default arguments of template specializations in the integration header when used in the kernel names of functors/lambdas. The printing happens unconditionally, regardless of whether the default argument is specified in the source code or not.