Skip to content

[UR][L0v2] Treat peers with statuses other than NO_CONNECTION as accessible for cross-device allocations #22580

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kswiecicki merged 1 commit into from
Jul 13, 2026
+2 −37
Merged

[UR][L0v2] Treat peers with statuses other than NO_CONNECTION as accessible for cross-device allocations #22580

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion unified-runtime/source/adapters/level_zero/v2/context.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -201,7 +201,8 @@ ur_context_handle_t_::getDevicesWhoseAllocationsCanBeAccessedFrom(
"there is no device:"
<< candidateId << " in peers table, number of devices:"
<< peers.size());
return peers[candidateId] == ur_device_handle_t_::PeerStatus::ENABLED;
return peers[candidateId] !=
ur_device_handle_t_::PeerStatus::NO_CONNECTION;
});

return retVal;
Expand Down
3 changes: 0 additions & 3 deletions unified-runtime/test/conformance/enqueue/urEnqueueMemBufferCopy.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -113,9 +113,6 @@ UUR_INSTANTIATE_PLATFORM_TEST_SUITE(urEnqueueMemBufferCopyMultiDeviceTest);
TEST_P(urEnqueueMemBufferCopyMultiDeviceTest, CopyReadDifferentQueues) {
UUR_KNOWN_FAILURE_ON(uur::CUDA{});

// Related issue: https://github.com/intel/llvm/issues/22058.
UUR_KNOWN_FAILURE_ON(uur::LevelZeroV2{"Data Center GPU Max"});

// First queue does a fill.
const uint32_t input = 42;
ASSERT_SUCCESS(urEnqueueMemBufferFill(
Expand Down
3 changes: 0 additions & 3 deletions unified-runtime/test/conformance/enqueue/urEnqueueMemBufferCopyRect.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -311,9 +311,6 @@ UUR_INSTANTIATE_PLATFORM_TEST_SUITE(urEnqueueMemBufferCopyRectMultiDeviceTest);
TEST_P(urEnqueueMemBufferCopyRectMultiDeviceTest, CopyRectReadDifferentQueues) {
UUR_KNOWN_FAILURE_ON(uur::CUDA{});

// Related issue: https://github.com/intel/llvm/issues/22058.
UUR_KNOWN_FAILURE_ON(uur::LevelZeroV2{"Data Center GPU Max"});

// First queue does a fill.
const uint32_t input = 42;
ASSERT_SUCCESS(urEnqueueMemBufferFill(
Expand Down
3 changes: 0 additions & 3 deletions unified-runtime/test/conformance/enqueue/urEnqueueMemBufferFill.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -212,9 +212,6 @@ using urEnqueueMemBufferFillMultiDeviceTest =
UUR_INSTANTIATE_PLATFORM_TEST_SUITE(urEnqueueMemBufferFillMultiDeviceTest);

TEST_P(urEnqueueMemBufferFillMultiDeviceTest, FillReadDifferentQueues) {
// Related issue: https://github.com/intel/llvm/issues/22058.
UUR_KNOWN_FAILURE_ON(uur::LevelZeroV2{"Data Center GPU Max"});

// First queue does a fill.
const uint32_t input = 42;
ASSERT_SUCCESS(urEnqueueMemBufferFill(
Expand Down
3 changes: 0 additions & 3 deletions unified-runtime/test/conformance/enqueue/urEnqueueMemBufferRead.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -138,9 +138,6 @@ using urEnqueueMemBufferReadMultiDeviceTest =
UUR_INSTANTIATE_PLATFORM_TEST_SUITE(urEnqueueMemBufferReadMultiDeviceTest);

TEST_P(urEnqueueMemBufferReadMultiDeviceTest, WriteReadDifferentQueues) {
// Related issue: https://github.com/intel/llvm/issues/22058.
UUR_KNOWN_FAILURE_ON(uur::LevelZeroV2{"Data Center GPU Max"});

// First queue does a blocking write of 42 into the buffer.
std::vector<uint32_t> input(count, 42);
ASSERT_SUCCESS(urEnqueueMemBufferWrite(queues[0], buffer, true, 0, size,
Expand Down
3 changes: 0 additions & 3 deletions unified-runtime/test/conformance/enqueue/urEnqueueMemBufferReadRect.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -277,9 +277,6 @@ UUR_INSTANTIATE_PLATFORM_TEST_SUITE(urEnqueueMemBufferReadRectMultiDeviceTest);

TEST_P(urEnqueueMemBufferReadRectMultiDeviceTest,
WriteRectReadDifferentQueues) {
// Related issue: https://github.com/intel/llvm/issues/22058.
UUR_KNOWN_FAILURE_ON(uur::LevelZeroV2{"Data Center GPU Max"});

// First queue does a blocking write of 42 into the buffer.
// Then a rectangular write the buffer as 1024x1x1 1D.
std::vector<uint32_t> input(count, 42);
Expand Down
21 changes: 0 additions & 21 deletions unified-runtime/test/conformance/memory-migrate/urMemBufferMigrateAcrossDevices.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -177,9 +177,6 @@ struct urMultiDeviceContextMemBufferTest : urMultiDeviceContextTest {
UUR_INSTANTIATE_PLATFORM_TEST_SUITE(urMultiDeviceContextMemBufferTest);

TEST_P(urMultiDeviceContextMemBufferTest, WriteRead) {
// Related issue: https://github.com/intel/llvm/issues/22058.
UUR_KNOWN_FAILURE_ON(uur::LevelZeroV2{"Data Center GPU Max"});

if (num_devices <= 1) {
GTEST_SKIP();
}
Expand All @@ -204,9 +201,6 @@ TEST_P(urMultiDeviceContextMemBufferTest, WriteRead) {
}

TEST_P(urMultiDeviceContextMemBufferTest, FillRead) {
// Related issue: https://github.com/intel/llvm/issues/22058.
UUR_KNOWN_FAILURE_ON(uur::LevelZeroV2{"Data Center GPU Max"});

if (num_devices <= 1) {
GTEST_SKIP();
}
Expand All @@ -231,9 +225,6 @@ TEST_P(urMultiDeviceContextMemBufferTest, FillRead) {
}

TEST_P(urMultiDeviceContextMemBufferTest, WriteKernelRead) {
// Related issue: https://github.com/intel/llvm/issues/22058.
UUR_KNOWN_FAILURE_ON(uur::LevelZeroV2{"Data Center GPU Max"});

if (num_devices <= 1) {
GTEST_SKIP();
}
Expand Down Expand Up @@ -271,9 +262,6 @@ TEST_P(urMultiDeviceContextMemBufferTest, WriteKernelRead) {
}

TEST_P(urMultiDeviceContextMemBufferTest, WriteKernelKernelRead) {
// Related issue: https://github.com/intel/llvm/issues/22058.
UUR_KNOWN_FAILURE_ON(uur::LevelZeroV2{"Data Center GPU Max"});

if (num_devices <= 1) {
GTEST_SKIP();
}
Expand Down Expand Up @@ -317,9 +305,6 @@ TEST_P(urMultiDeviceContextMemBufferTest, WriteKernelKernelRead) {
}

TEST_P(urMultiDeviceContextMemBufferTest, PingPongKernelExecution) {
// Related issue: https://github.com/intel/llvm/issues/22058.
UUR_KNOWN_FAILURE_ON(uur::LevelZeroV2{"Data Center GPU Max"});

if (num_devices <= 1) {
GTEST_SKIP();
}
Expand Down Expand Up @@ -368,9 +353,6 @@ TEST_P(urMultiDeviceContextMemBufferTest, PingPongKernelExecution) {
}

TEST_P(urMultiDeviceContextMemBufferTest, ComplexMigrationPattern) {
// Related issue: https://github.com/intel/llvm/issues/22058.
UUR_KNOWN_FAILURE_ON(uur::LevelZeroV2{"Data Center GPU Max"});

if (num_devices <= 1) {
GTEST_SKIP();
}
Expand Down Expand Up @@ -437,9 +419,6 @@ TEST_P(urMultiDeviceContextMemBufferTest, ComplexMigrationPattern) {
}

TEST_P(urMultiDeviceContextMemBufferTest, KernelsExecutionWithThreads) {
// Related issue: https://github.com/intel/llvm/issues/22058.
UUR_KNOWN_FAILURE_ON(uur::LevelZeroV2{"Data Center GPU Max"});

if (num_devices <= 1) {
GTEST_SKIP();
}
Expand Down
Loading