[SYCL] Fix -Wunused-template errors in headers#22583
Merged
Merged
Conversation
-Wunused-template was enabled under -Wall upstream (clang commit 1529d35), which now flags several `static` function templates in SYCL headers as unused within a single translation unit (they are only referenced from other TUs or from unevaluated contexts). Drop `static` from these templates, matching the fix already applied upstream for the analogous OpenMP __kmp_wait case. External linkage is fine as compiler will safely handle duplicate definitions across multiple TUs. Fix SYCL::warnings/warnings.cpp in CMPLRLLVM-76767. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
-Wunused-template was enabled under -Wall upstream (clang commit 1529d35), which now flags several
staticfunction templates in SYCL headers as unused within a single translation unit (they are only referenced from other TUs or from unevaluated contexts). Dropstaticfrom these templates, matching the fix already applied upstream for the analogous OpenMP __kmp_wait case. External linkage is fine as compiler will safely handle duplicate definitions across multiple TUs.Fix SYCL::warnings/warnings.cpp in CMPLRLLVM-76767.