[SSAF] Fix Expected return type in TypeConstrainedPointers deserialization (gcc 7.5.0) - #22727
Merged
Merged
Conversation
…ation (gcc 7.5.0) GCC 7.5.0 fails to compile this code. Use explicit upcasts from std::unique_ptr to std::unique_ptr in deserializeSummary and deserializeAnalysisResult. This resolves a compilation error where llvm::Expected<std::unique_ptr> could not be constructed from unique_ptr of derived summary/result types. --- See: llvm/llvm-project#211331 This file has been renamed in the upstream. The PR above should fix the issue in the new file. This one is to fix the toolchain build with gcc 7.5.0 before pulldown.
Contributor
Author
|
@intel/dpcpp-cfe-reviewers I’d really appreciate a quick review; the patch is trivial. |
elizabethandrews
approved these changes
Jul 22, 2026
elizabethandrews
left a comment
elizabethandrews
left a comment
Contributor
There was a problem hiding this comment.
This looks ok to me but @premanandrao can you also take a look so I am not missing any unexpected consequences
Contributor
|
@intel/llvm-gatekeepers please consider merging |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GCC 7.5.0 fails to compile this code. Use explicit upcasts from std::unique_ptr to std::unique_ptr in deserializeSummary and deserializeAnalysisResult. This resolves a compilation error where llvm::Expectedstd::unique_ptr could not be constructed from unique_ptr of derived summary/result types.
See: llvm/llvm-project#211331
This file has been renamed in the upstream. The PR above should fix the issue in the upstream.
This one is to fix the toolchain build with gcc 7.5.0 before pulldown.