Skip to content

[SYCL][UT] Eliminate concurrent read-write of mock callbacks map - #22872

Merged
KornevNikita merged 1 commit into
intel:syclfrom
KseniyaTikhomirova:super_flaky_ut_scheduler
Aug 5, 2026
Merged

[SYCL][UT] Eliminate concurrent read-write of mock callbacks map#22872
KornevNikita merged 1 commit into
intel:syclfrom
KseniyaTikhomirova:super_flaky_ut_scheduler

Conversation

@KseniyaTikhomirova

@KseniyaTikhomirova KseniyaTikhomirova commented Aug 5, 2026

Copy link
Copy Markdown
Contributor

Initial test implementation allowed concurrent read and write of "before_callbacks" map. After the first part of test where host task is present Q.wait() guarantees all HT work to be finished but some post processing (including memory release) can continue. That post processing can call UR methods (e.g. urEventRelease and others) if needed (read access). The second part of test was updating one of the maps in ur mock (write access). This behavior is UB.
Split test to 2 separate tests to remove incorrect usage of UR mock functionality.

Signed-off-by: Tikhomirova, Kseniya <kseniya.tikhomirova@intel.com>
@KseniyaTikhomirova
KseniyaTikhomirova requested a review from a team as a code owner August 5, 2026 12:15
@KseniyaTikhomirova

KseniyaTikhomirova commented Aug 5, 2026

Copy link
Copy Markdown
Contributor Author

failed tests are not related. I updated only 1 UT test.

Linux: Failed Tests (1):
SYCL :: bindless_images/vulkan_interop/vulkan_sycl_image_interop_write_1d_unsampled.cpp

Windows:
Failed Tests (1):
SYCL :: Adapters/level_zero/batch_event_status.cpp
Another windows failure (hang) can't be rel;ated as well. SchedulerTests are currently completely excluded from Win scope.

@KseniyaTikhomirova

Copy link
Copy Markdown
Contributor Author

@intel/llvm-gatekeepers hi, please consider merging this. Reported failures can't be related.

@KornevNikita
KornevNikita merged commit 90f4ed6 into intel:sycl Aug 5, 2026
28 of 31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants