[SYCL][UT] Eliminate concurrent read-write of mock callbacks map - #22872
Merged
KornevNikita merged 1 commit intoAug 5, 2026
Merged
Conversation
Signed-off-by: Tikhomirova, Kseniya <kseniya.tikhomirova@intel.com>
sergey-semenov
approved these changes
Aug 5, 2026
Contributor
Author
|
failed tests are not related. I updated only 1 UT test. Linux: Failed Tests (1): Windows: |
Contributor
Author
|
@intel/llvm-gatekeepers hi, please consider merging this. Reported failures can't be related. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Initial test implementation allowed concurrent read and write of "before_callbacks" map. After the first part of test where host task is present Q.wait() guarantees all HT work to be finished but some post processing (including memory release) can continue. That post processing can call UR methods (e.g. urEventRelease and others) if needed (read access). The second part of test was updating one of the maps in ur mock (write access). This behavior is UB.
Split test to 2 separate tests to remove incorrect usage of UR mock functionality.