[UR][CMake] Fix broken if(TARGET) check for level-zero-loader targets - #22896
Merged
Conversation
foreach(TARGET IN ITEMS ze_loader ze_validation_layer ze_tracing_layer ze_null) used `if (TARGET TARGET)`, which checks for a target literally named "TARGET" instead of dereferencing the loop variable. This silently skipped add_ur_target_compile_options()/add_ur_target_link_options() (which apply -no-intel-lib=libirc for IntelLLVM) on ze_loader and its siblings, so icx/icpx compiled level-zero-loader sources with default _intel_fast_memcpy/_intel_fast_memset emission and nothing provided those symbols, causing undefined symbol link errors downstream. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
pbalcer
approved these changes
Aug 7, 2026
Contributor
Author
|
@intel/llvm-gatekeepers please merge thanks, e2e fails are unrelated to this PR |
Contributor
|
failure: #21023 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
foreach(TARGET IN ITEMS ze_loader ze_validation_layer ze_tracing_layer ze_null) used
if (TARGET TARGET), which checks for a target literally named "TARGET" instead of dereferencing the loop variable. This silently skipped add_ur_target_compile_options()/add_ur_target_link_options() (which apply -no-intel-lib=libirc for IntelLLVM) on ze_loader and its siblings, so icx/icpx compiled level-zero-loader sources with default _intel_fast_memcpy/_intel_fast_memset emission and nothing provided those symbols, causing undefined symbol link errors downstream.