[SYCL] Add feature macro for the matrix extension - #3564
Merged
Conversation
Pennycook
previously approved these changes
Apr 16, 2021
Contributor
Author
|
ping? @bader |
alexbatashev
previously approved these changes
Apr 17, 2021
yubingex007-a11y
dismissed stale reviews from alexbatashev and Pennycook
via
April 17, 2021 16:23
9ac124a
alexbatashev
approved these changes
Apr 17, 2021
Pennycook
approved these changes
Apr 17, 2021
Contributor
Author
|
@bader, it seems the merging is still blocked. Do we need appeoval from other reviewers? |
Contributor
It says "Merging is blocked" because you don't have permissions to press the merge button. Otherwise, it should be fine. You have all the necessary approvals, and all tests have passed. |
bader
changed the title
jsji
pushed a commit
that referenced
this pull request
Mar 19, 2026
No extensions/ nor DebugInfo/ tests are touched. For tests that are failing appropriate TODO and FIXME are added. Variants of errors: 1. llc crash run on the test (5 tests), can be found by grep LLC_FAIL; 2. llvm-spirv -r crash when reverse translating llc-generated SPIR-V (5 tests), can be found by grep LLVM_SPIRV_R_FAIL; 3. FileCheck missmatches that are not yet investigated as a part of this patch (a number of tests),can be found by grep FILECHECK_FAIL. Note, few IR samples in llvm-spirv LITs are producing empty SPIR-V modules when compiled with SPIR-V backend due to DCE. This has to be fixed. Original commit: KhronosGroup/SPIRV-LLVM-Translator@cb7e40b4725f764
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.