[WIP][SYCL][ESIMD] Replace mask_type_t with simd_mask to represent Gen predicates.#3787
Closed
kbobrovs wants to merge 1 commit into
Closed
[WIP][SYCL][ESIMD] Replace mask_type_t with simd_mask to represent Gen predicates.#3787kbobrovs wants to merge 1 commit into
kbobrovs wants to merge 1 commit into
Conversation
…dicates. Represents a Gen simd operation mask. Aims to have similar interface to std::experimantal::simd_mask: (https://github.com/llvm/llvm-project/blob/main/libcxx/include/experimental/simd) Compared to std::experimantal::simd_mask, this implementation * does not provide the following members/features: - abi_type (not needed for ESIMD) - simd_type (not needed for ESIMD) - reference (TODO) - implicit type conversion constructor (not needed for ESIMD) - reference operator[](size_t) (TODO) - flags in memory load/store operations (TODO) - reduction functions (TODO): any_of, all_of, some_of, none_of, popcount, find_first_set, find_last_set * additionally provides some extra features, like - broadcast constructor for any integer type - implicit conversion from the simd class - constructor from fixed-size array - ... few more Signed-off-by: kbobrovs <Konstantin.S.Bobrovsky@intel.com>
kbobrovs
requested review from
DenisBakhvalov,
cmc-rep,
kychendev and
rolandschulz
May 20, 2021 02:11
Contributor
|
Contributor
Author
|
Replaced with #4230 |
iclsrc
pushed a commit
that referenced
this pull request
Jul 17, 2026
… WordCount (#3787) Following up on #3671, this adds additional guardrails for cases that were still unhandled by the previous patch. This PR also includes multiple new tests for invalid wordcounts, and joins them all --the new, and the ones added by #3671-- in their own directory (test/negative/invalid-wordcount). Original commit: KhronosGroup/SPIRV-LLVM-Translator@a1441b281976ff1
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch introduces simd_mask class which represents a Gen simd operation mask.
Aims to have similar interface to std::experimantal::simd_mask:
(https://github.com/llvm/llvm-project/blob/main/libcxx/include/experimental/simd)
Compared to std::experimantal::simd_mask, this implementation
any_of, all_of, some_of, none_of, popcount, find_first_set, find_last_set
TODO (WIP): select and iupdate operations
This patch addresses this review comment:
// TODO @rolandschulz on May 21
// {quote}
// - The mask should also be a wrapper around the clang - vector type rather
// than the clang - vector type itself.
// - The internal storage should be implementation defined.uint16_t is a bad
// choice for some HW.Nor is it how clang - vector types works(using the same
// size int as the corresponding vector type used for comparison(e.g. long for
// double and int for float)).
E2E test: intel/llvm-test-suite#286
Signed-off-by: kbobrovs Konstantin.S.Bobrovsky@intel.com