[SYCL] Enable memcpy in libdevice - #3879
Merged
Merged
Conversation
Signed-off-by: gejin <ge.jin@intel.com>
jinge90
requested review from
a team,
AGindinson,
AlexeySachkov,
kbobrovs,
mdtoguchi,
mlychkov and
vzakhari
as code owners
June 4, 2021 03:43
kbobrovs
reviewed
Jun 4, 2021
Signed-off-by: gejin <ge.jin@intel.com>
bader
previously requested changes
Jun 4, 2021
Contributor
Author
|
/suumary:run |
Signed-off-by: gejin <ge.jin@intel.com>
romanovvlad
previously approved these changes
Jun 7, 2021
Pennycook
previously approved these changes
Jun 7, 2021
AlexeySachkov
previously approved these changes
Jun 8, 2021
AlexeySachkov
left a comment
AlexeySachkov
left a comment
Contributor
There was a problem hiding this comment.
sycl-post-link changes LGTM
vzakhari
previously approved these changes
Jun 8, 2021
vzakhari
left a comment
vzakhari
left a comment
Contributor
There was a problem hiding this comment.
libdevice changes look good to me.
jinge90
dismissed stale reviews from vzakhari, AlexeySachkov, Pennycook, and romanovvlad
via
June 16, 2021 01:44
c7a52c1
Signed-off-by: gejin <ge.jin@intel.com>
bader
changed the title
Contributor
|
@AGindinson, @mdtoguchi, ping. |
vzakhari
approved these changes
Jun 23, 2021
mdtoguchi
approved these changes
Jun 23, 2021
Contributor
Author
|
Hi, @bader and @romanovvlad |
Contributor
No, it cannot be. |
mlychkov
approved these changes
Jul 8, 2021
This was referenced Jul 8, 2021
Michoumichmich
added a commit
to Michoumichmich/llvm
that referenced
this pull request
Sep 10, 2021
This reverts commit 76051cc.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: gejin ge.jin@intel.com
Currently, memcpy is supported in SYCL device code if "-fno-builtin" is not added. Compiler will convert it to "llvm.memcpy..." intrinsic and llvm-spirv will convert it to OpCopyMemorySized for jit.
However, if "-fno-builtin" is added, compiler will call libc function "memcpy" directly and it requires libdevice support. This PR support memcpy in libdevice, so developers can use it in SYCL device code no matter whether "-fno-builtin" is added or not.