Skip to content

[SYCL] Fix unused variable warning detected by post-commit tests#3884

Merged
bader merged 3 commits into
intel:syclfrom
dm-vodopyanov:private/dvodopya/fix-post-commit
Jun 4, 2021
Merged

[SYCL] Fix unused variable warning detected by post-commit tests#3884
bader merged 3 commits into
intel:syclfrom
dm-vodopyanov:private/dvodopya/fix-post-commit

Conversation

@dm-vodopyanov

Copy link
Copy Markdown
Contributor

No description provided.

@dm-vodopyanov
dm-vodopyanov requested a review from a team as a code owner June 4, 2021 12:35
alexbatashev
alexbatashev previously approved these changes Jun 4, 2021
Comment thread sycl/source/detail/allowlist.cpp Outdated
alexbatashev
alexbatashev previously approved these changes Jun 4, 2021
@bader bader changed the title Fix post-commit after PR #3826 [SYCL] Fix unused variable warning detected by post-commit tests Jun 4, 2021
@dm-vodopyanov

Copy link
Copy Markdown
Contributor Author

Add missing include

I didn't add <algorithm> explicitly, because it covers by <regex> both for Linux and Windows:

https://godbolt.org/z/qxhzMrn7o

@bader

bader commented Jun 4, 2021

Copy link
Copy Markdown
Contributor

Add missing include

I didn't add explicitly, because it covers by both for Linux and Windows:

https://godbolt.org/z/qxhzMrn7o

Does C++ spec requires regex to include algorithm implicitly?

@dm-vodopyanov

Copy link
Copy Markdown
Contributor Author

Does C++ spec requires regex to include algorithm implicitly?

Fair enough, these are implementation details.

@bader
bader merged commit 2827893 into intel:sycl Jun 4, 2021
@dm-vodopyanov
dm-vodopyanov deleted the private/dvodopya/fix-post-commit branch February 10, 2022 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants