Fix overlapping memcpy when filtering TLVs by id - #134
Open
Hashim1999164 wants to merge 1 commit into
Open
Conversation
get_tlvs compacted matching TLVs with memcpy even when the source and destination overlapped, which corrupted filtered neighbor TLV output. Also stop delivering a TLV to later modules once one returns TLV_OK so a handler that frees the TLV cannot leave a use after free. Fixes: intel#127 Signed-off-by: Hashim1999164 <sardarhashim30@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When lldptool requests a single TLV id, get_tlvs compact matching entries forward with memcpy. Source and destination can overlap, so the copied bytes were corrupted (seen as garbled Port Description output). Switch that copy to memmove.
Separately, ieee8023_rchange can free a TLV and return TLV_OK while rxProcessFrame still walked later modules with that pointer. Stop the module walk once a handler returns TLV_OK so the next module cannot hit a use after free.
Closes #127
Test plan