Skip to content
This repository was archived by the owner on Aug 5, 2022. It is now read-only.

Android: Link to shared library xmlSerializer#8

Merged
krocard merged 1 commit intomasterfrom
remove_include_library_trick
Jun 10, 2015
Merged

Android: Link to shared library xmlSerializer#8
krocard merged 1 commit intomasterfrom
remove_include_library_trick

Conversation

@krocard
Copy link
Copy Markdown
Contributor

@krocard krocard commented Jun 9, 2015

The Parameter Framework has recently removed (this trick was not working on osx) its *_include libraries. They were used to include headers without linking against the libraries in the android build system.

There is two way to include headers from a library:

  • copy the headers (but that would be in contradiction with how the main pfw headers are included)
  • link against the library (chosen solution)

To avoid linking against a static libxmlserializer - ie add it and its dependency to all plugins - the xmlserializer library is now dynamic.

Link against the dynamic library xmlserializer and no longer use *_include.

@OznOg
Copy link
Copy Markdown

OznOg commented Jun 10, 2015

👍

@dawagner
Copy link
Copy Markdown
Contributor

commit/PR message issues:

  • s/PFw/Parameter Framework/
  • "as" -> "has"
  • "it's *_include libraries" -> "its *_includes libraries"

@dawagner
Copy link
Copy Markdown
Contributor

Apart from that, 👍

The Parameter Framework has recently removed
(this trick was not working on osx)
its *_include libraries. They were used to include headers
without linking against the libraries in the android build system.

There is two way to include headers from a library:
 - copy the headers (but that would be in contradiction
   with how the main pfw headers are included)
 - link against the library (chosen solution)

To avoid linking against a static libxmlserializer
- ie add it and its dependency to all plugins -
the xmlserializer library is now dynamic.

Link against the dynamic library xmlserializer and no longer use *_include.

Change-Id: I1811a7ab1c5f892adadb8709b8fefa58ebad4542
Signed-off-by: Kevin Rocard <kevin.rocard@intel.com>
@krocard krocard force-pushed the remove_include_library_trick branch from 48ee967 to 636eb1d Compare June 10, 2015 09:48
krocard added a commit that referenced this pull request Jun 10, 2015
Android: Link to shared library xmlSerializer

The Parameter Framework has recently removed (this trick was not working on osx) its *_include libraries. They were used to include headers without linking against the libraries in the android build system.

There is two way to include headers from a library:
 - copy the headers (but that would be in contradiction with how the main pfw headers are included)
 - link against the library (chosen solution)

To avoid linking against a static libxmlserializer - ie add it and its dependency to all plugins - the xmlserializer library is now dynamic.

Link against the dynamic library xmlserializer and no longer use *_include.
@krocard krocard merged commit b56a3e8 into master Jun 10, 2015
@krocard krocard deleted the remove_include_library_trick branch June 10, 2015 13:42
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants