This repository was archived by the owner on Aug 5, 2022. It is now read-only.
vasprintf fails by returning -1 #27
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krocard
force-pushed
the
vasprintf_error_detection
branch
from
2f3f28e to
f75cc99
Compare
Contributor
|
+1 |
2 similar comments
Contributor
Author
|
👍 |
Contributor
|
👍 |
krocard
force-pushed
the
vasprintf_error_detection
branch
from
f75cc99 to
56ba10d
Compare
Contributor
Author
|
Commits were rebased without modification due to github refusing to merge them otherwise. |
Contributor
Author
|
@dawagner Can you review ? This pull request is 4 month old now ! |
Contributor
|
The varargs are going away thanks to @clero 's pull request anyway. |
Contributor
Author
|
I guess you are talking about #58. I agree that this pull request is far better. Nevertheless I hope it will be merged one day. Nobody reviewed it yet and their is still opened questions about it (especially the commits delegating log to clients). Plus this pull request is rather small and easy to rebased on. |
Contributor
Author
|
Reopen because #58 was never merged in master and the rebase will not be that difficult if it is merged (just delete the function). |
Handling of varadic log formating. It used to be duplicated in 4 functions. Create a new vLog function, taking a va_list as parameter and formating the log. All 4 previous mention varadic argument log functions now forward their argument to vLog. Signed-off-by: Kevin Rocard <kevinx.rocard@intel.com>
krocard
force-pushed
the
vasprintf_error_detection
branch
from
56ba10d to
f340537
Compare
int vasprintf(char **strp, const char *fmt, va_list ap) return -1 on failure, not by setting strp to NULL. Replace check for NULL by checking for -1 return. Signed-off-by: Kevin Rocard <kevinx.rocard@intel.com>
krocard
force-pushed
the
vasprintf_error_detection
branch
from
f340537 to
b7bfb4b
Compare
Contributor
|
👎 |
Contributor
Author
|
Solved by log rework in #168 will be merged in windows_port then master shortly. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
int vasprintf(char **strp, const char *fmt, va_list ap)
return -1 on failure, not by setting strp to NULL.
Replace check for NULL by checking for -1 return.
