Skip to content
This repository was archived by the owner on Aug 5, 2022. It is now read-only.

Log rework #58

Closed
wants to merge 13 commits into from
Closed

Log rework #58

wants to merge 13 commits into from

Conversation

@clero
Copy link
Contributor

@clero clero commented Mar 5, 2015

Log rework to remove them for Element class.
It will require plugins update.

@clero
Copy link
Contributor Author

clero commented Mar 5, 2015

👍 @makohoek @krocard @dawagner @OznOg @gdenneul

@clero clero mentioned this pull request Mar 13, 2015
Closed
@clero
Copy link
Contributor Author

clero commented Mar 20, 2015

This pull request conflicts with c bindings as those bindings assume that no status can be returned in case of a success.
This pull request introduces an information retrieval possibility for the client when a criterion is set. This information allows the client to gather some information about criterion applications (number of change since last apply).
Maybe the solution is to give the possibility to set a list a criterion, the apply would be useless and so will be the information.

REBASED: c bindings can now return an info string on success.

@clero clero force-pushed the log branch 3 times, most recently from 62ca857 to ffc8bf0 Compare March 23, 2015 08:15
@clero
Copy link
Contributor Author

clero commented Mar 31, 2015

Add Android compilation support 👍

@clero clero mentioned this pull request Mar 31, 2015
Closed
@dawagner
Copy link
Contributor

dawagner commented Apr 3, 2015

merged into the 'clang' branch.

@clero clero force-pushed the log branch 2 times, most recently from b2fd667 to 1a09070 Compare April 7, 2015 07:56
@clero
Copy link
Contributor Author

clero commented Apr 7, 2015

rebased on functional tests

@krocard krocard mentioned this pull request Apr 7, 2015
Closed
2 tasks
@clero clero force-pushed the log branch 2 times, most recently from 2fcc350 to 4188f4f Compare April 8, 2015 09:53
dawagner
dawagner reviewed Apr 8, 2015
View reviewed changes
parameter/ConfigurableDomain.h Outdated
Copy link
Contributor

@dawagner dawagner Apr 8, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not related to this pull request. Please remove & feel free to open a ticket.

Copy link
Contributor Author

@clero clero Apr 9, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are only talking about the FIXME right?

Copy link
Contributor

@dawagner dawagner Apr 9, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

right (although one could argue that the documentation could first be added in a separate patch and then updated when adding the 'infos' argument ;)).

Copy link
Contributor Author

@clero clero Apr 9, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

dawagner
dawagner reviewed Apr 8, 2015
View reviewed changes
parameter/log/include/log/Logger.h Outdated
Copy link
Contributor

@dawagner dawagner Apr 8, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file doesn't seem to be used by anyone.

Copy link
Contributor Author

@clero clero Apr 9, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I forgot to remove it

dawagner
dawagner reviewed Apr 10, 2015
View reviewed changes
parameter/CMakeLists.txt Outdated
Copy link
Contributor

@dawagner dawagner Apr 10, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2014-2015

Copy link
Contributor Author

@clero clero Apr 10, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@dawagner
Copy link
Contributor

dawagner commented Apr 10, 2015

Please rebase against the master branch (conflicts are minor).

clero added 13 commits April 10, 2015 15:47
@clero
Remove unused AutoLog header from SelectionCriterion class
56b6ea9 
Signed-off-by: Jules Clero <julesx.clero@intel.com>
@clero
Move logging up to ParameterMgr
869536a 
Some elements are logging but ParameterMgr is able
to do the same.
This patch lets the ParameterMgr handle logging
whenever it's possible.

Signed-off-by: Jules Clero <julesx.clero@intel.com>
@clero
Introduce Results type to avoid copy paste
76bce4e 
String lists are often used as containers for function results.
To avoid copy paste, this patch introduces the Results type
to replace std::list<std::string> when relevant.
Documentation has been updated on modified prototype.

Signed-off-by: Jules Clero <julesx.clero@intel.com>
@clero
Remove plugin load attempt log
adeeee9 
This log is meaningless, as we know subsystems we are
attempting to load. We log only if there is an error.

Signed-off-by: Jules Clero <julesx.clero@intel.com>
@clero
Remove unused XmlFileIncluderElement header from ParameterMgr
46d1d2c 
Signed-off-by: Jules Clero <julesx.clero@intel.com>
@clero
Remove log from XmlFileIncluderElement
6870135 
This log information is easy to retrieve by looking
the structure file.

Signed-off-by: Jules Clero <julesx.clero@intel.com>
@clero
Delegate addValuePair error logging to client
d84367b 
The client may choose if he wants to log the error
when adding a criterion.

Signed-off-by: Jules Clero <julesx.clero@intel.com>
@clero
Temporarily remove Subsystems logging ability
146e0a9 
In prevision of logging rework, this patch
removes logging from plugins.

Signed-off-by: Jules Clero <julesx.clero@intel.com>
@clero
Rework project log
f4e9b34 
Logs were provided by Element god class. This patch
moves logging in the log library which is used by
the ParameterMgr.
Logs remains almost identical from before.
Context title after context closing bracket has been
removed to enhance readability.

Change-Id: Ic7dca65c3cc88eb06a1883c4fb01af9809b19e42
Signed-off-by: Jules Clero <julesx.clero@intel.com>
@clero
Remove unused remote-processor include location from test-subsystem
d87f399 
Signed-off-by: Jules Clero <julesx.clero@intel.com>
@clero
Enable subsystems logging
ca709d8 
Plugins are now able to log.
An ILogger object is provided to plugins to do that.

Signed-off-by: Jules Clero <julesx.clero@intel.com>
@clero
Update Skeleton Subsystem for log ability.
4f69f42 
Signed-off-by: Jules Clero <julesx.clero@intel.com>
@clero
Update domainGenerator python script to use the new log API
d9d84b9 
Change-Id: Ib31547b3f899f96b837ac125ea7b0feb8c946760
Signed-off-by: Jules Clero <julesx.clero@intel.com>
@clero
Copy link
Contributor Author

clero commented Apr 10, 2015

rebase done

@clero clero mentioned this pull request Apr 10, 2015
Closed
@dawagner
Copy link
Contributor

dawagner commented Apr 13, 2015

replaced by #87

@dawagner dawagner closed this Apr 13, 2015
@clero clero deleted the log branch April 27, 2015 07:35
@dawagner dawagner added this to the Version 3 milestone Jun 1, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

clang enhancement

Projects

None yet

Milestone

Version 3

Development

Successfully merging this pull request may close these issues.

3 participants

@clero @dawagner @krocard