This repository was archived by the owner on Aug 5, 2022. It is now read-only.
Port log rework from next #168
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jules Clero <julesx.clero@intel.com>
Some elements are logging but ParameterMgr is able to do the same. This patch lets the ParameterMgr handle logging whenever it's possible. Signed-off-by: Jules Clero <julesx.clero@intel.com>
String lists are often used as containers for function results. To avoid copy paste, this patch introduces the Results type to replace std::list<std::string> when relevant. Documentation has been updated on modified prototype. Signed-off-by: Jules Clero <julesx.clero@intel.com>
This log is meaningless, as we know subsystems we are attempting to load. We log only if there is an error. Signed-off-by: Jules Clero <julesx.clero@intel.com>
Signed-off-by: Jules Clero <julesx.clero@intel.com>
This log information is easy to retrieve by looking the structure file. Signed-off-by: Jules Clero <julesx.clero@intel.com>
The client may choose if he wants to log the error when adding a criterion. Signed-off-by: Jules Clero <julesx.clero@intel.com>
In prevision of logging rework, this patch removes logging from plugins. Signed-off-by: Jules Clero <julesx.clero@intel.com>
uint8_t type seems to be buggy when we try to log it through stream API. This patch uses uint32_t type instead to count criterion modifications. Signed-off-by: Jules Clero <julesx.clero@intel.com>
Logs were provided by Element god class. This patch moves logging in the log library which is used by the ParameterMgr. Logs remains almost identical from before. Context title after context closing bracket has been removed to enhance readability. Change-Id: Ic7dca65c3cc88eb06a1883c4fb01af9809b19e42 Signed-off-by: Jules Clero <julesx.clero@intel.com>
Signed-off-by: Jules Clero <julesx.clero@intel.com>
Plugins are now able to log. An ILogger object is provided to plugins to do that. Signed-off-by: Jules Clero <julesx.clero@intel.com>
Signed-off-by: Jules Clero <julesx.clero@intel.com>
Change-Id: Ib31547b3f899f96b837ac125ea7b0feb8c946760 Signed-off-by: Jules Clero <julesx.clero@intel.com>
krocard
force-pushed
the
port_log_from_next
branch
from
a092854 to
939da49
Compare
bindings/c/ParameterFramework.cpp
Outdated
Contributor
Author
There was a problem hiding this comment.
should not be in this pull request
krocard
force-pushed
the
port_log_from_next
branch
from
939da49 to
0ad5644
Compare
Contributor
Author
Merged
krocard
force-pushed
the
port_log_from_next
branch
2 times, most recently
from
2745788 to
0ad5644
Compare
bindings/c/ParameterFramework.cpp
Outdated
Contributor
|
👎 |
This was referenced Aug 27, 2015
krocard
force-pushed
the
port_log_from_next
branch
2 times, most recently
from
fb11d68 to
0d577c3
Compare
Port log rework from next in order to remove dependancies on snprintf and because it was pending. Conflicts: parameter/Android.mk parameter/ConfigurableDomain.cpp parameter/ConfigurableDomains.cpp parameter/Element.cpp parameter/Element.h parameter/ParameterMgr.cpp parameter/ParameterMgr.h parameter/SelectionCriterion.cpp parameter/SubsystemObject.cpp parameter/SubsystemObject.h parameter/SystemClass.cpp utility/CMakeLists.txt
Signed-off-by: Kevin Rocard <kevin.rocard@intel.com>
std::make_unique is a function that alocates an object and wraps it in a std::unique_ptr. This helper function is very useful for unique_ptr manibulation. Unfortunately the proposal missed the C++11 time frame and was adopted in C++14. As is implementation is very straightforward, port it in the PF. Signed-off-by: Kevin Rocard <kevin.rocard@intel.com>
Fix the leak by managing the object life cycle with an unique_ptr. Signed-off-by: Kevin Rocard <kevin.rocard@intel.com>
krocard
force-pushed
the
port_log_from_next
branch
from
0d577c3 to
161bfb1
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Port log rework (#87) from next in order to remove dependencies on *sprintf that does not have the same behavior on windows.
Additionally fixed a leak introduced by #87 (port make_unique for that)
