This repository was archived by the owner on Aug 5, 2022. It is now read-only.
Clang compilation #77
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clero
force-pushed
the
clang
branch
16 times, most recently
from
e4cecdc to
3914408
Compare
Contributor
There was a problem hiding this comment.
you meant _pLogger->warning, right ?
Contributor
Author
|
rebased on functional tests |
Signed-off-by: Jules Clero <julesx.clero@intel.com>
Some elements are logging but ParameterMgr is able to do the same. This patch lets the ParameterMgr handle logging whenever it's possible. Signed-off-by: Jules Clero <julesx.clero@intel.com>
String lists are often used as containers for function results. To avoid copy paste, this patch introduces the Results type to replace std::list<std::string> when relevant. Documentation has been updated on modified prototype. Signed-off-by: Jules Clero <julesx.clero@intel.com>
This log is meaningless, as we know subsystems we are attempting to load. We log only if there is an error. Signed-off-by: Jules Clero <julesx.clero@intel.com>
Signed-off-by: Jules Clero <julesx.clero@intel.com>
This log information is easy to retrieve by looking the structure file. Signed-off-by: Jules Clero <julesx.clero@intel.com>
The client may choose if he wants to log the error when adding a criterion. Signed-off-by: Jules Clero <julesx.clero@intel.com>
In prevision of logging rework, this patch removes logging from plugins. Signed-off-by: Jules Clero <julesx.clero@intel.com>
uint8_t type seems to be buggy when we try to log it through stream API. This patch uses uint32_t type instead to count criterion modifications. Signed-off-by: Jules Clero <julesx.clero@intel.com>
Logs were provided by Element god class. This patch moves logging in the log library which is used by the ParameterMgr. Logs remains almost identical from before. Context title after context closing bracket has been removed to enhance readability. Change-Id: Ic7dca65c3cc88eb06a1883c4fb01af9809b19e42 Signed-off-by: Jules Clero <julesx.clero@intel.com>
Signed-off-by: Jules Clero <julesx.clero@intel.com>
Plugins are now able to log. An ILogger object is provided to plugins to do that. Signed-off-by: Jules Clero <julesx.clero@intel.com>
Signed-off-by: Jules Clero <julesx.clero@intel.com>
Change-Id: Ib31547b3f899f96b837ac125ea7b0feb8c946760 Signed-off-by: Jules Clero <julesx.clero@intel.com>
Signed-off-by: David Wagner <david.wagner@intel.com>
Contributor
|
please rebase and resubmit against "next". |
init function is defined in Element god class but is used only for plugins initialization after structure and settings loading. This patch delegate Subsystem initialization to SystemClass which is the direct parent. Signed-off-by: Jules Clero <julesx.clero@intel.com>
The element class really looks like a god class with stuff that has really nothing to do with its role. toString and appendTitle are good example of stuff that should be move away from it. This patch move those two functions into utility where they seems to belong. Signed-off-by: Sébastien Gonzalve <oznog@users.noreply.github.com> Signed-off-by: Jules Clero <julesx.clero@intel.com>
SelectionCriteria class is dependant from Element class because of the checksum calculation algorithm which is based on child name. In preparation of a rework, we exclude it from the structure checksum calculation. Moreover the criterion mechanism is not a part of the parameter-framework structure. Thus, this decision is fair. Signed-off-by: Jules Clero <julesx.clero@intel.com>
ParameterManager does not have to be a part of the Element tree. Indeed, it is not represented in any xml file. This patch avoids this inheritance and removes some "tricks" which was used to forget the ParameterMgr root element. Signed-off-by: Jules Clero <julesx.clero@intel.com>
Swig does not any more generates code which require this flag. Moreover this flag is not present in clang compiler. Change-Id: I386ab576e93003d69dcf2c593670245070770024 Signed-off-by: Jules Clero <julesx.clero@intel.com>
accessAsInteger function prototype is defined in BaseParameter abstract class with an uint32_t type. Nevertheless in BitParameter the overloaded function take an uin64_t. It seems that GCC accepts wrongly this mistake but clang don't. This patch corrects the function prototype accordingly to the one defined in BaseParameter. It allows the project to be compiled with clang. Signed-off-by: Jules Clero <julesx.clero@intel.com>
Clang compiler allows to use some great features in the Android PDK (like c++11). Change-Id: Ic80c04b0aff88aa947b3a07c6f35314cc4a7de28 Signed-off-by: Jules Clero <julesx.clero@intel.com>
Swig has been updated in order to avoid the use of Wno-unused-but-set-variable flag which is not present in Clang. The coverage is not supported for now due to gcov compatibility problems with clang. The debug build his also built in a different directory to avoid an empty error of python bindings with clang. Signed-off-by: Jules Clero <julesx.clero@intel.com>
Contributor
Author
|
replaced by #94 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on log rework: #58
Add clang support to parameter-framework project.
Clang comes in Android with its standard library which supports c++11.