Restore SystemVerilog port defaults and add per-direction type configuration - #687
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description & Motivation
The explicit/implicit port type configuration added in #678 changed the default generated SystemVerilog from ROHD's historical port declarations:
input logicoutput logicinout wireto fully explicit declarations:
input wire logicoutput var logicinout wire logicThis caused compatibility issues in some downstream flows. It also exposed a limitation in the original configuration: a single object/data type policy cannot represent the historical defaults because inout ports require different settings from input and output ports.
This PR restores the historical generated declarations by default and makes object and data type emission independently configurable for each port direction.
SystemVerilogPortTypeConfigurationfor controlling object and data type emission together.inputPortType,outputPortType, andinOutPortTypesettings toSystemVerilogSynthesizerConfiguration.input logicoutput logicinout wireRelated Issue(s)
#678
Testing
Added new tests
Backwards-compatibility
No (previous PR changes are not released yet)
Documentation
Yes, included