-
Notifications
You must be signed in to change notification settings - Fork 17
Adds Handwritten Digit Recognition example #43
Conversation
a8fd2dd to
17d9abf
Compare
| x = self.conv1(x) | ||
| x = F.relu(x) | ||
| x = self.conv2(x) | ||
| x = F.max_pool2d(x, 2) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is there are reason why no activation fn is given here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @DnPlas does this network perform well, without a non linear activation here?
unrahul
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
some comments, please see.
| help="number of epochs to train (default: 10)", | ||
| ) | ||
| parser.add_argument( | ||
| "--lr", type=float, default=1.0, metavar="LR", help="learning rate (default: 0.01)" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: change default=0.01 :)
| parser.add_argument( | ||
| "--test-batch-size", | ||
| type=int, | ||
| default=1000, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
may be make it same as the training batch, 64 ?
unrahul
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
minor nits, otherwise looks okay to me, thank you @DnPlas
* Python scripts for training, classifying and model serving * Docker images for all tasks mentioned above Signed-off-by: Daniela Plascencia <daniela.plascencia@linux.intel.com>
Signed-off-by: Daniela Plascencia <daniela.plascencia@linux.intel.com>
Signed-off-by: Daniela Plascencia <daniela.plascencia@linux.intel.com>
unrahul
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @DnPlas merging .
Adding the Handwritten Digit Recognition based on DLRS, Pytorch and MNIST.
This series introduces the following changes: