Remove dead scripts - #104
Merged
Merged
Conversation
save-setting (singular, one key=value at a time) - superseded by save-settings (plural, bulk-writes the whole file), which is what's actually called from server.go. delete-recore-config, flash-direct, set-boot-media, and get-boot-media aren't called from anywhere - server.go, any other script, mkimage.sh, or the Makefile beyond a stale chmod line for the latter two. set-boot-media/get-boot-media had no bin/prod equivalent to begin with, only these unused bin/dev copies. flash-recore (also chmod'd in install_bins, also otherwise uncalled) is left alone for now - its bin/prod equivalent still exists under a new name (flash-from-file).
Looked dead by the earlier survey and is - it's a partial prototype toward #86 (writes a hardcoded klipper-led_effect provisioning script to the eMMC, missing the UI text editor and the runner service that would actually execute it on first boot), not something usable as-is. The actual #86 implementation should start fresh rather than build on this.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
save-setting(singular, one key=value at a time) is superseded bysave-settings(plural, bulk-writes the whole file), which is what's actually called fromserver.go.delete-recore-config,flash-direct,set-boot-media,get-boot-media, andfirst-bootaren't called from anywhere -server.go, any other script,mkimage.sh, or theMakefilebeyond a stalechmodline for two of them.set-boot-media/get-boot-mediahad nobin/prodequivalent to begin with, only these unusedbin/devcopies.first-bootis a partial prototype toward #86 (writes a hardcoded klipper-led_effect provisioning script to the eMMC, missing the UI text editor and the runner service that would actually execute it on first boot) - not something usable as-is, so removed rather than kept as a stale starting point.Not touched:
flash-recore(also chmod'd ininstall_bins, also otherwise uncalled) - itsbin/prodequivalent still exists under a new name (flash-from-file), left as-is for now.Testing
make test-bats/go test ./...- no regressions.