wifi-connect: bump DHCP wait from 10s to 30s - #92
Merged
Conversation
10s to get an IP after the connection is accepted is tight, especially on links that have already shown other timing sensitivity this session. Same reasoning as the Rebuild-side CLIENT_TIMEOUT bump: worst case this just adds a few seconds to a failed attempt, but a too-short wait can report a spurious failure on a connection that would have come up fine given a bit more time. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
10s to get an IP after the connection is accepted is tight, especially on links that have already shown other timing sensitivity this session.
Same reasoning as the Rebuild-side
CLIENT_TIMEOUTbump (30s -> 60s): worst case this just adds a few seconds to a failed attempt, but a too-short wait can report a spurious failure on a connection that would have come up fine given a bit more time.🤖 Generated with Claude Code