docs(ux-nav): close out spec — flip [active]→[landed] + refresh §1/§4/§5#655
Merged
Conversation
…ns 1/4/5 to match realised UX Audit-and-align pass surfaced 5 findings against docs/specs/2026-03-25-ux-navigation-improvements-design.md: 1. SettingsTab enum has 5 variants in code (Profile, Server, Roles, Presence, Notifications); spec listed only the original 3. Presence + Notifications were added by Phase 1e/1f. Updated the enum example + tab listing to match. 2. Server context menu has 2 items in code (Server Settings, Leave Server), not the 3 the spec listed. The standalone "Invite" entry was dropped because invite generation is reachable from the Server settings tab. Documented the dropped item with the rationale. 3. Quick Peer ID Copy lives in the profile-card popover, not as a sidebar icon. Phase 2c consolidated all self-profile actions into the popover to keep the always-visible sidebar uncluttered. Rewrote §5 to describe the realised shape and note the supersession. 4. `ServerList` was renamed to `GroveRail` during the Phase 1a desktop-shell refactor. Updated §4 implementation note. 5. `leave_server` is now actor-based (mutates `server_registry_addr` via `willow_actor::state::mutate`); the spec described direct SharedState mutation + explicit storage calls. Rewrote the `leave_server()` block to describe the actor-pipeline shape and added a migration note. Added Date/Status/Implementation plan header per the docs-organization convention (PR #653). README master index flipped [active] → [landed]. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Audit-and-align pass against
docs/specs/2026-03-25-ux-navigation-improvements-design.mdfound 5 findings, all docs-only spec refreshes:ServerListwas renamed toGroveRailduring Phase 1a desktop-shell refactor. Updated §4 implementation note.leave_serveris actor-based, not direct SharedState mutation. Updated the implementation block + added migration note.Added Date/Status/Implementation plan header per the docs-organization convention (PR #653).
README master index flipped
[active]→[landed].Test plan
🤖 Generated with Claude Code