fix(web-basic): make documented dev command work from clean install - #39
Merged
Conversation
- Fix root dev:web-basic script to use pnpm --dir instead of wrong package filter (@intent/web-basic does not exist; the actual package name is web-basic) - Add Vite resolve aliases for @intent/core, @intent/dom, @intent/router so Vite resolves workspace packages from source during development, eliminating the need for pnpm build before pnpm dev:web-basic - Update docs/Demo.md to mention the root command as an alternative to the cd-based path Validation (from clean dist): pnpm test: 310 tests passed (127 core + 72 router + 21 testing + 4 server + 86 dom) pnpm typecheck: passes pnpm build: passes (all packages + vite build) pnpm dev:web-basic: Vite starts cleanly in <150ms with no resolution errors
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix two bugs that prevented
pnpm dev:web-basicfrom working after a cleanpnpm install:@intent/web-basicdoes not exist)@intent/*workspace packages without a priorpnpm buildChanges
dev:web-basicscript:--filter @intent/web-basic→--dir examples/web-basicexamples/web-basic/vite.config.ts: added resolve aliases for@intent/core,@intent/dom,@intent/routerpointing to source filesdocs/Demo.md: mention rootpnpm dev:web-basiccommand as primary pathValidation (from clean dist)
Fixes #38 reported behavior. The demo can now be run with just
pnpm install && pnpm dev:web-basicas documented in README.