Many improvements. #299
Many improvements. #299
Conversation
| steps: | ||
| - checkout | ||
| - run: composer install --no-interaction | ||
| - run: composer install --no-interaction --no-suggest --prefer-dist |
There was a problem hiding this comment.
Prefer dist, and no need to display suggested packages.
| @@ -1,2 +1,2 @@ | |||
| exclude_paths: | |||
| - test/* | |||
| - test/* | |||
There was a problem hiding this comment.
Respect .editorconfig file
| @@ -0,0 +1,15 @@ | |||
| root = true | |||
|
|
|||
| [*] | |||
There was a problem hiding this comment.
Add a standard .editorconfig file.
| /.codeclimate.yml export-ignore | ||
| * text=auto | ||
|
|
||
| /.circleci export-ignore |
There was a problem hiding this comment.
Sort folders, hidden files and files that don't need to be exported.
|
|
||
| # PhpStorm | ||
| .idea | ||
| /.idea |
There was a problem hiding this comment.
Properly prefix folders and un-prefix files
| /.idea | ||
|
|
||
| # Composer | ||
| /vendor |
There was a problem hiding this comment.
Also, sort folders, then hidden files, the files
| "name": "intercom/intercom-php", | ||
| "description": "Intercom API client built on top of Guzzle 6", | ||
| "keywords": ["intercom", "intercom.io", "api", "guzzle"], | ||
| "keywords": [ |
There was a problem hiding this comment.
Format and sort keywords
| { | ||
| "name": "Intercom Platform Team", | ||
| "homepage": "http://intercom.io" | ||
| "homepage": "https://www.intercom.com" |
There was a problem hiding this comment.
Update homepage
| "homepage": "https://www.intercom.com" | ||
| } | ||
| ], | ||
| "support": { |
There was a problem hiding this comment.
Add support section
| "autoload": { | ||
| "psr-4": { | ||
| "Intercom\\": ["src"] | ||
| "Intercom\\": [ |
There was a problem hiding this comment.
Default composer formatting
| "php": ">= 7.1", | ||
| "ext-json": "*", | ||
| "php-http/httplug": "^1.0 || ^2.0", | ||
| "php-http/client-common": "^1.9 || ^2.0", |
| convertWarningsToExceptions="true" | ||
| processIsolation="false" | ||
| stopOnFailure="false"> | ||
| stopOnFailure="false" |
GabrielAnca
left a comment
GabrielAnca
left a comment
There was a problem hiding this comment.
Looks great, thank you for taking care of this!
2 participants
Why?
Why are you making this change?
We want to add many small improvements to this project.
How?
Technical details on your change
See comments in code for the detailed changes