-
Notifications
You must be signed in to change notification settings - Fork 146
Many improvements. #299
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Many improvements. #299
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,2 +1,2 @@ | ||
| exclude_paths: | ||
| - test/* | ||
| - test/* | ||
|
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Respect |
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,15 @@ | ||
| root = true | ||
|
|
||
| [*] | ||
|
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Add a standard |
||
| charset = utf-8 | ||
| end_of_line = lf | ||
| indent_size = 4 | ||
| indent_style = space | ||
| insert_final_newline = true | ||
| trim_trailing_whitespace = true | ||
|
|
||
| [*.md] | ||
| trim_trailing_whitespace = false | ||
|
|
||
| [*.yml] | ||
| indent_size = 2 | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,5 +1,10 @@ | ||
| /test export-ignore | ||
| /phpunit.xml export-ignore | ||
| /.github export-ignore | ||
| /.circleci export-ignore | ||
| /.codeclimate.yml export-ignore | ||
| * text=auto | ||
|
|
||
| /.circleci export-ignore | ||
|
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Sort folders, hidden files and files that don't need to be exported. |
||
| /.github export-ignore | ||
| /test export-ignore | ||
| .codeclimate.yml export-ignore | ||
| .editorconfig export-ignore | ||
| .gitattributes export-ignore | ||
| .gitignore export-ignore | ||
| phpunit.xml.dist export-ignore | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -2,17 +2,17 @@ | |
| .DS_Store | ||
|
|
||
| # PhpStorm | ||
| .idea | ||
| /.idea | ||
|
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Properly prefix folders and un-prefix files |
||
|
|
||
| # Composer | ||
| /vendor | ||
|
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Also, sort folders, then hidden files, the files |
||
| composer.lock | ||
| composer.phar | ||
| /vendor | ||
|
|
||
| # PhpUnit | ||
| phpunit.phar | ||
| /phpunit.xml | ||
| phpunit.xml | ||
|
|
||
| # Extras | ||
| build/ | ||
| /build | ||
| *.swp | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,37 +1,53 @@ | ||
| { | ||
| "name": "intercom/intercom-php", | ||
| "description": "Intercom API client built on top of Guzzle 6", | ||
| "keywords": ["intercom", "intercom.io", "api", "guzzle"], | ||
| "keywords": [ | ||
|
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Format and sort keywords |
||
| "api", | ||
| "guzzle", | ||
| "intercom", | ||
| "intercom.io" | ||
| ], | ||
| "license": "Apache-2.0", | ||
| "authors": [ | ||
| { | ||
| "name": "Intercom Platform Team", | ||
| "homepage": "http://intercom.io" | ||
| "homepage": "https://www.intercom.com" | ||
|
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Update homepage |
||
| } | ||
| ], | ||
| "support": { | ||
|
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Add support section |
||
| "issues": "https://github.com/intercom/intercom-php/issues", | ||
| "source": "https://github.com/intercom/intercom-php" | ||
| }, | ||
| "autoload": { | ||
| "psr-4": { | ||
| "Intercom\\": ["src"] | ||
| "Intercom\\": [ | ||
|
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Default composer formatting |
||
| "src" | ||
| ] | ||
| } | ||
| }, | ||
| "autoload-dev": { | ||
| "psr-4": { | ||
| "Intercom\\Test\\": ["test"] | ||
| "Intercom\\Test\\": [ | ||
| "test" | ||
| ] | ||
| } | ||
| }, | ||
| "require": { | ||
| "php": ">= 7.1", | ||
| "ext-json": "*", | ||
| "php-http/httplug": "^1.0 || ^2.0", | ||
| "php-http/client-common": "^1.9 || ^2.0", | ||
|
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Sort packages |
||
| "php-http/client-implementation": "*", | ||
| "php-http/discovery": "^1.4", | ||
| "php-http/httplug": "^1.0 || ^2.0", | ||
| "php-http/message": "^1.7", | ||
| "psr/http-message": "^1.0", | ||
| "php-http/client-common": "^1.9 || ^2.0" | ||
| "psr/http-message": "^1.0" | ||
| }, | ||
| "require-dev": { | ||
| "php-http/guzzle6-adapter": "^1.0 || ^2.0", | ||
| "phpunit/phpunit": "^7.0", | ||
| "squizlabs/php_codesniffer": "^3.1", | ||
| "php-http/guzzle6-adapter": "^1.0 || ^2.0" | ||
| "squizlabs/php_codesniffer": "^3.1" | ||
| }, | ||
| "config": { | ||
| "sort-packages": true | ||
| } | ||
| } | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -7,7 +7,8 @@ | |
| convertNoticesToExceptions="true" | ||
| convertWarningsToExceptions="true" | ||
| processIsolation="false" | ||
| stopOnFailure="false"> | ||
| stopOnFailure="false" | ||
|
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Formatting |
||
| > | ||
| <testsuites> | ||
| <testsuite name="Intercom Test Suite"> | ||
| <directory suffix=".php">./test/</directory> | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Prefer dist, and no need to display suggested packages.