Raise error when API rate limit is exceeded.#43
Raise error when API rate limit is exceeded.#43vedarthk wants to merge 1 commit intointercom:masterfrom
Conversation
As mentioned in API documentation of Intercom: http://doc.intercom.io/api/#rate-limiting This will raise `ApiRateLimitExceededError` if Intercom sends Too many requests (429) response.
|
Hi @vedarthk. Thanks for this. Sorry about the outrageous delay in responding. The v1 code is no longer being worked on (master branch), the ongoing development is happening on the v2 branch (currently apiv2). The biggest omission from that version is error handling which I plan on resolving soon. I'll refer back to this PR when I get there. Thanks for contributing. |
|
@jkeyes ok! |
|
@vedarthk I've added rate limiting support and followed how the intercom-ruby library did it. The code is all in the |
|
@jkeyes great, will update once released. |
|
@vedarthk 2.0.alpha now on PyPI https://pypi.python.org/pypi/python-intercom/2.0.alpha |
2 participants
As mentioned in API documentation of Intercom:
http://doc.intercom.io/api/#rate-limiting
This will raise
ApiRateLimitExceededErrorif Intercom sends Toomany requests (429) response.
Also, will it be helpful if we attach HTTP response to
ApiRateLimitExceededError?