fix(HttpSignature): require content-digest when request body present - #9
Open
SashaMIT wants to merge 1 commit into
Open
Conversation
Signature-Input that omitted content-digest previously validated when a body was present (fail-open), allowing the body to be swapped under an otherwise valid signature. Align with open-payments-go: if the request has a body, content-digest must be covered and verified.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes proposed in this pull request
When a request has a body,
validateSigInputComponentsnow requirescontent-digestto be covered by Signature-Input and verified (along with content-length / content-type). Previously, omittingcontent-digestfailed open: a Signature-Input covering only@method/@target-uri/ etc. could validate while the body was swapped.Context
Sibling of interledger/open-payments-go#50 and the matching Node fix in
open-payments-node(@interledger/http-signature-utils). Tip verified at7cca666907f2376f8dd51d9f707e0a4da722f292.Test plan
content-digestin Signature-Input (expected for Open Payments / GNAP)Made with Cursor