handle new error behaviour in python 3.7 - fixes #40#44
handle new error behaviour in python 3.7 - fixes #40#44julie-sullivan merged 1 commit intointermine:devfrom
Conversation
|
Does this include changes in #38? |
|
No - should it? |
|
okay, it appears that the same commit passed on the PR pipeline even though it failed on my personal branch. Let's pretend my branch never failed as it's clearly some sort of environment issue. 😭 |
|
|
Hmmmm.
The big one in ListManager is really hard to review as it's a mix of whitespace and actual code changes. It would be nice to leave it until later.
This only affects from intermine.webservice import Service
service = Service("www.flymine.org/flymine/service")
template = service.get_template('Gene_Pathway')
print("flymine", template.views)If it doesn't error under python 3.7 (and no other errors crop up - I'd suggest running both test suites) then we should be good to go! To test different python versions, I did this to create a new environment (assuming you have anaconda installed): conda create -n template_bug35 python=3.5
conda activate template_bug35
conda install -c bioconda interminereplace with 3.7 in the above code to test in python 3.7. You'll need to install intermine (the python package) each time you activate a new environment
cool - let me know if you think it's ready / once this is merged! :) |
|
Tested! Works great! Ready to publish. |
small fix for #40. This fixes it on my machine when running 3.7.
Travis is failing on environmental setup issues (Java) and I can't figure out why. This is four lines different from the intermine dev branch!
@julie-sullivan could you help by any chance? It would be nice to have this available for the GCC workshop next week.