Skip to content

Empty lists can not be uploaded#64

Merged
yochannah merged 2 commits intointermine:devfrom
mbasil09:patch-1
Dec 10, 2019
Merged

Empty lists can not be uploaded#64
yochannah merged 2 commits intointermine:devfrom
mbasil09:patch-1

Conversation

@mbasil09
Copy link
Copy Markdown
Contributor

No description provided.

@pep8speaks
Copy link
Copy Markdown

pep8speaks commented Dec 10, 2019

Hello @mbasil09! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2019-12-10 06:26:17 UTC

@yochannah yochannah self-requested a review December 10, 2019 13:05
Copy link
Copy Markdown
Member

@yochannah yochannah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works exactly as expected - nice! I've tested creating an empty list and a non-empty - both behave as expected. 💯 🏆 thank you!

@yochannah yochannah merged commit b331f27 into intermine:dev Dec 10, 2019
@mbasil09 mbasil09 deleted the patch-1 branch December 12, 2019 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants