Python 3.7 Upgrade ( Issue #73 )

[asherpasha]

This pull request is for Issue #73. So far, we have the following:

• Change the FlyMine url to https

• Ran dos2unix. (Readability fix!)

• Update the requirements to support Python 3.8

Still to do:

• ThaleMine URL (and tests)

• Ten tests are still failing

• Travis

[pep8speaks]

Hello @asherpasha! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

• In the file intermine/constraints.py:

Line 250:21: E741 ambiguous variable name 'l'

• In the file intermine/model.py:

Line 866:1: W293 blank line contains whitespace
Line 868:13: E303 too many blank lines (2)
Line 926:21: E129 visually indented line with same indent as next logical line

• In the file intermine/query.py:

Line 51:80: E501 line too long (87 > 79 characters)
Line 75:80: E501 line too long (131 > 79 characters)
Line 155:80: E501 line too long (88 > 79 characters)
Line 159:80: E501 line too long (82 > 79 characters)
Line 216:80: E501 line too long (86 > 79 characters)
Line 269:80: E501 line too long (95 > 79 characters)
Line 364:80: E501 line too long (82 > 79 characters)
Line 365:80: E501 line too long (90 > 79 characters)
Line 512:80: E501 line too long (80 > 79 characters)
Line 890:80: E501 line too long (85 > 79 characters)
Line 896:80: E501 line too long (81 > 79 characters)
Line 907:80: E501 line too long (81 > 79 characters)
Line 1051:80: E501 line too long (88 > 79 characters)
Line 1093:80: E501 line too long (81 > 79 characters)
Line 1324:80: E501 line too long (80 > 79 characters)
Line 1325:80: E501 line too long (80 > 79 characters)
Line 1335:80: E501 line too long (89 > 79 characters)
Line 1456:55: W291 trailing whitespace
Line 1475:80: E501 line too long (93 > 79 characters)
Line 1668:9: E741 ambiguous variable name 'l'
Line 1904:80: E501 line too long (92 > 79 characters)
Line 1909:80: E501 line too long (83 > 79 characters)

• In the file intermine/results.py:

Line 107:80: E501 line too long (102 > 79 characters)
Line 108:80: E501 line too long (130 > 79 characters)
Line 166:80: E501 line too long (89 > 79 characters)
Line 176:80: E501 line too long (89 > 79 characters)
Line 333:80: E501 line too long (80 > 79 characters)
Line 349:80: E501 line too long (96 > 79 characters)
Line 407:80: E501 line too long (91 > 79 characters)
Line 408:80: E501 line too long (82 > 79 characters)
Line 409:80: E501 line too long (91 > 79 characters)
Line 410:80: E501 line too long (104 > 79 characters)
Line 655:80: E501 line too long (83 > 79 characters)

• In the file tests/live_lists.py:

Line 58:80: E501 line too long (80 > 79 characters)
Line 121:80: E501 line too long (91 > 79 characters)
Line 165:80: E501 line too long (91 > 79 characters)
Line 212:80: E501 line too long (80 > 79 characters)
Line 648:13: E741 ambiguous variable name 'l'

• In the file tests/test_core.py:

Line 56:80: E501 line too long (82 > 79 characters)
Line 80:80: E501 line too long (89 > 79 characters)
Line 163:80: E501 line too long (155 > 79 characters)
Line 164:80: E501 line too long (147 > 79 characters)
Line 165:80: E501 line too long (156 > 79 characters)
Line 166:80: E501 line too long (85 > 79 characters)
Line 167:80: E501 line too long (123 > 79 characters)
Line 168:80: E501 line too long (167 > 79 characters)
Line 169:80: E501 line too long (147 > 79 characters)
Line 170:80: E501 line too long (82 > 79 characters)
Line 180:80: E501 line too long (100 > 79 characters)
Line 193:80: E501 line too long (100 > 79 characters)
Line 202:80: E501 line too long (100 > 79 characters)
Line 212:80: E501 line too long (100 > 79 characters)
Line 215:80: E501 line too long (98 > 79 characters)
Line 223:80: E501 line too long (97 > 79 characters)
Line 226:80: E501 line too long (98 > 79 characters)
Line 227:80: E501 line too long (94 > 79 characters)
Line 229:80: E501 line too long (85 > 79 characters)
Line 240:80: E501 line too long (102 > 79 characters)
Line 243:80: E501 line too long (98 > 79 characters)
Line 244:80: E501 line too long (94 > 79 characters)
Line 246:80: E501 line too long (85 > 79 characters)
Line 258:80: E501 line too long (90 > 79 characters)
Line 266:80: E501 line too long (81 > 79 characters)
Line 275:80: E501 line too long (81 > 79 characters)
Line 304:14: E741 ambiguous variable name 'l'
Line 353:80: E501 line too long (93 > 79 characters)
Line 368:80: E501 line too long (88 > 79 characters)
Line 374:80: E501 line too long (83 > 79 characters)
Line 377:80: E501 line too long (84 > 79 characters)
Line 401:80: E501 line too long (110 > 79 characters)
Line 527:80: E501 line too long (83 > 79 characters)
Line 576:44: E711 comparison to None should be 'if cond is None:'
Line 577:45: E711 comparison to None should be 'if cond is not None:'
Line 578:48: E711 comparison to None should be 'if cond is None:'
Line 626:80: E501 line too long (98 > 79 characters)
Line 630:80: E501 line too long (87 > 79 characters)
Line 699:80: E501 line too long (83 > 79 characters)
Line 747:80: E501 line too long (94 > 79 characters)
Line 826:80: E501 line too long (99 > 79 characters)
Line 846:80: E501 line too long (988 > 79 characters)
Line 858:80: E501 line too long (859 > 79 characters)
Line 863:33: E711 comparison to None should be 'if cond is not None:'
Line 866:80: E501 line too long (83 > 79 characters)
Line 879:34: E711 comparison to None should be 'if cond is not None:'
Line 882:80: E501 line too long (84 > 79 characters)
Line 897:80: E501 line too long (192 > 79 characters)
Line 906:80: E501 line too long (104 > 79 characters)
Line 907:80: E501 line too long (94 > 79 characters)
Line 913:80: E501 line too long (99 > 79 characters)
Line 923:38: E711 comparison to None should be 'if cond is not None:'
Line 924:80: E501 line too long (80 > 79 characters)
Line 938:80: E501 line too long (236 > 79 characters)
Line 939:80: E501 line too long (228 > 79 characters)
Line 940:80: E501 line too long (210 > 79 characters)
Line 941:80: E501 line too long (112 > 79 characters)
Line 942:80: E501 line too long (201 > 79 characters)
Line 943:80: E501 line too long (109 > 79 characters)
Line 944:80: E501 line too long (177 > 79 characters)
Line 945:80: E501 line too long (221 > 79 characters)
Line 998:80: E501 line too long (303 > 79 characters)
Line 1007:80: E501 line too long (303 > 79 characters)
Line 1016:80: E501 line too long (303 > 79 characters)
Line 1127:80: E501 line too long (88 > 79 characters)
Line 1223:34: W601 .has_key() is deprecated, use 'in'
Line 1224:34: W601 .has_key() is deprecated, use 'in'
Line 1225:38: W601 .has_key() is deprecated, use 'in'

• In the file tests/test_templates.py:

Line 34:80: E501 line too long (81 > 79 characters)
Line 188:80: E501 line too long (135 > 79 characters)
Line 197:80: E501 line too long (109 > 79 characters)
Line 201:80: E501 line too long (110 > 79 characters)

Comment last updated at 2020-10-09 03:18:16 UTC