Optionally send outlinks to 2nd HQ project#465
Optionally send outlinks to 2nd HQ project#465NGTmeaty merged 5 commits intointernetarchive:mainfrom
Conversation
Add new options `--hq-outlinks-project` and `--hq-outlinks-hop-limit`. Send outlinks with hops >= `hq-outlinks-hop-limit` to the `hq-outlinks-project` via the special `hqOutlinksProduceChan` channel.
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #465 +/- ##
==========================================
+ Coverage 55.33% 56.45% +1.12%
==========================================
Files 128 130 +2
Lines 7939 8091 +152
==========================================
+ Hits 4393 4568 +175
+ Misses 3183 3157 -26
- Partials 363 366 +3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
The identification of outlinks to send to We init the 2nd HQ client like this:
I don't understand why we get this error. We send I'm using the following command to run Zeno. Then, I add a URL to the |
|
I believe I have seen that websocket error in production as well. I meant to create an issue but it shouldn't be effecting anything in this PR. I will take another look today. |
|
I know what the problem is. |
We need 2 instances, one for main source and one for sending outlinks to a different project (optional)
|
I have resolved the issues, this is ready for review / merge. BTW, the error: |
CorentinB
left a comment
There was a problem hiding this comment.
It all looks good to me, but if I may, I think --hq-outlinks-hop-limit not being explicitely described and explained is a problem. I think that it is unclear what it does.
|
@CorentinB thank you for the suggestion, I added an extra comment for |
Thanks. Can it be added in the command itself so that it's explained when someone does -h? |
|
Yes, why not. Done! |
Add new options
--hq-outlinks-projectand--hq-outlinks-hop-limit.Send outlinks with hops >=
hq-outlinks-hop-limitto thehq-outlinks-projectvia the specialhqOutlinksProduceChanchannel.