Skip to content

Revert #465#503

Merged
NGTmeaty merged 1 commit intomainfrom
revert-hq-outlinks
Sep 29, 2025
Merged

Revert #465#503
NGTmeaty merged 1 commit intomainfrom
revert-hq-outlinks

Conversation

@NGTmeaty
Copy link
Copy Markdown
Collaborator

Fixes #502

@NGTmeaty NGTmeaty requested a review from vbanos September 28, 2025 20:03
@NGTmeaty NGTmeaty self-assigned this Sep 28, 2025
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Sep 28, 2025

Codecov Report

❌ Patch coverage is 16.21622% with 31 lines in your changes missing coverage. Please review.
✅ Project coverage is 56.25%. Comparing base (051e7e2) to head (0215b8c).
⚠️ Report is 49 commits behind head on main.

Files with missing lines Patch % Lines
internal/pkg/source/hq/hq.go 0.00% 31 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #503      +/-   ##
==========================================
+ Coverage   56.22%   56.25%   +0.02%     
==========================================
  Files         130      130              
  Lines        8119     8096      -23     
==========================================
- Hits         4565     4554      -11     
+ Misses       3184     3175       -9     
+ Partials      370      367       -3     
Flag Coverage Δ
e2etests 40.50% <16.21%> (-0.03%) ⬇️
unittests 29.36% <0.00%> (+0.08%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@willmhowes
Copy link
Copy Markdown
Collaborator

A little more context - @NGTmeaty found:

When creating the second client, we are also creating HQ consumer. It seems like this is causing it to pull URLs from both the main collection and the outlinks collection.

Therefore, this PR specifically fixes #502 by reverting #465 and removing the --hq-outlinks-project featureset from Zeno. We will look to reimplement such a feature in the seed source rather than the crawler.

@willmhowes willmhowes added the bug Something isn't working label Sep 29, 2025
Copy link
Copy Markdown
Collaborator

@willmhowes willmhowes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Successfully compiled and testing crawling locally using this branch, good to merge on my end

@NGTmeaty NGTmeaty merged commit 0458982 into main Sep 29, 2025
5 checks passed
@NGTmeaty NGTmeaty deleted the revert-hq-outlinks branch September 29, 2025 21:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

New HQ outlinks feature hurts modularity

3 participants