Skip to content

Fix Mode1Up initial zoom#1153

Closed
cdrini wants to merge 1 commit intomasterfrom
cdrini-patch-1
Closed

Fix Mode1Up initial zoom#1153
cdrini wants to merge 1 commit intomasterfrom
cdrini-patch-1

Conversation

@cdrini
Copy link
Copy Markdown
Contributor

@cdrini cdrini commented Feb 24, 2023

Closes #1130 .

Also fixes runaway scroll when going FS on mobile from 2up.

Before on page load After on page load
image image

Tested on:

  • Windows/FF
  • Windows/Chrome

@codecov
Copy link
Copy Markdown

codecov Bot commented Feb 24, 2023

Codecov Report

Merging #1153 (9293dda) into master (47efad1) will not change coverage.
The diff coverage is 0.00%.

❗ Current head 9293dda differs from pull request most recent head c8750f7. Consider uploading reports for the commit c8750f7 to get more accurate results

@@           Coverage Diff           @@
##           master    #1153   +/-   ##
=======================================
  Coverage   70.00%   70.00%           
=======================================
  Files          59       59           
  Lines        5320     5320           
  Branches     1037     1037           
=======================================
  Hits         3724     3724           
  Misses       1577     1577           
  Partials       19       19           
Impacted Files Coverage Δ
src/BookReader/Mode1UpLit.js 83.10% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@cdrini cdrini changed the title Fix Mode1Up default zoom Fix Mode1Up initial zoom Sep 1, 2023
@cdrini
Copy link
Copy Markdown
Contributor Author

cdrini commented Sep 5, 2023

Closed in favour of #1230

@cdrini cdrini closed this Sep 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Initial zoom wrong on mobile 1up

1 participant