WEBDEV-8777 Apply ia-button custom active styles for .active class - #65
Merged
Merged
Conversation
The custom variant's active-state selector only matched the native :hover/:focus/:active pseudo-classes, so elements that toggle a persistent .active class via JS never got the active styling.
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #65 +/- ##
=======================================
Coverage 78.62% 78.62%
=======================================
Files 17 17
Lines 697 697
Branches 189 189
=======================================
Hits 548 548
Misses 100 100
Partials 49 49 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
nsharma123
enabled auto-merge (squash)
July 29, 2026 08:23
nsharma123
disabled auto-merge
July 29, 2026 08:23
jbuckner
approved these changes
Jul 29, 2026
jbuckner
added a commit
that referenced
this pull request
Aug 3, 2026
Resolves the one conflict: 0.2.11 (#69) bumped package-lock.json on main and this branch deletes it, so the deletion wins. package.json auto-merged and picked up the 0.2.11 version along with #65's ia-button changes; the pnpm bits, the lit dual range and the prettier pin all came through unchanged. Lockfile needed no update since neither commit touched deps. The PR had gone CONFLICTING, which is also why App CI stopped running on the last two pushes: GitHub can't build a merge ref for a dirty PR, so the pull_request workflows never fired. Clean frozen install, build, madge and 164 tests pass. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Nou2gTKyfJ1Z2gL4RjVqdS
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The custom variant's active-state selector only matched the native :hover/:focus/:active pseudo-classes, so elements that toggle a persistent .active class via JS never got the active styling.
https://webarchive.jira.com/browse/WEBDEV-8777